⚓ T210460 Eliminate usage of mocha-eslint

Subject	Repo	Branch	Lines +/-
build: Remove mocha-eslint because it is no longer maintained	mediawiki/services/chromium-render	master	+5 -240
Replace istanbul with nyc	mediawiki/services/recommendation-api	master	+114 -126
Eliminate mocha-eslint	mediawiki/services/mathoid	master	+133 -184
Remove jshint && mocha-eslint	mediawiki/services/citoid	master	+8 -51

Status	Assigned	Task
Resolved	• Pchelolo	T210460 Eliminate usage of mocha-eslint
Resolved	• holger.knust	T218386 Invalid peer dependencies between eslint and plugins
Resolved	Aacaldwell	T238935 Eliminate usage of mocha-eslint from proton
Resolved	KartikMistry	T238936 Eliminate usage of mocha-eslint from cxserver
Resolved	Ottomata	T238937 Eliminate usage of mocha-eslint from eventstreams
Declined	None	T239087 Remove mocha-eslint in graphoid

• Mholloway created this task.Nov 26 2018, 10:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 26 2018, 10:29 PM

Jdforrester-WMF subscribed.Nov 26 2018, 10:32 PM

• Pchelolo edited projects, added Services (later), Platform Team Legacy (Later), User-Clarakosi; removed Services.Nov 26 2018, 10:32 PM

• Pchelolo updated the task description. (Show Details)

• Mholloway updated the task description. (Show Details)Nov 27 2018, 12:55 AM

PR to remove it from the service template: https://github.com/wikimedia/service-template-node/pull/110

phuedx mentioned this in T210652: Handoff Proton service to Reading Infrastructure.Nov 30 2018, 1:19 PM

• Pchelolo mentioned this in T213222: Recommendation API improvements.Jan 8 2019, 10:30 PM

• Pchelolo updated the task description. (Show Details)Jan 9 2019, 8:02 PM

• holger.knust subscribed.Jan 15 2019, 7:49 PM

Simply replacing the usage of mocha-eslint with latest version of eslint is not a full solution - given that eslint-config-node-services declares eslint as a peer dependency, that creates a peer dependency conflict like T212722

There's been an attempt to unify the configs for javascript within the foundation and as a result eslint-config-wikimedia/server was created. There exist some unanswered questions on which features have to be upstreamed to the Wikimedia config (T211138 and https://github.com/wikimedia/eslint-config-wikimedia/issues/133 ) and how the services have to be changed to accommodate the new config.

As a first step towards finally switching to unified eslint-config-wikimedia, I propose to use this task to collect data on still missing non-unified pieces (tabs vs spaces) is an obvious one. So the services and libs mentioned in the task description have to begin using 'esilnt-config-wikimedia/server' and explicitly use service-specific overrides in .eslintrc of each service required for the linting to pass without changing the codebase.

Doing that for at least a subset of repos and having pull requests with explicit lists in place will allow us to finally see what needs to be upstreamed, what needs to change in the codebase and what needs to stay as a service-specific override.

Ok, I'll remove eslint-config-node-services then and override where necessary

• holger.knust updated the task description. (Show Details)Jan 24 2019, 4:56 PM

• holger.knust updated the task description. (Show Details)Jan 24 2019, 11:04 PM

• holger.knust updated the task description. (Show Details)Jan 25 2019, 2:15 PM

• holger.knust updated the task description. (Show Details)Jan 25 2019, 4:39 PM

• holger.knust updated the task description. (Show Details)Jan 25 2019, 5:17 PM

Change 488908 had a related patch set uploaded (by Mvolz; owner: Mvolz):
[mediawiki/services/citoid@master] Remove jshint && mocha-eslint

https://gerrit.wikimedia.org/r/488908

gerritbot added a project: Patch-For-Review.Feb 7 2019, 11:27 AM

Mvolz subscribed.Feb 7 2019, 11:33 AM

Change 488908 merged by jenkins-bot:
[mediawiki/services/citoid@master] Remove jshint && mocha-eslint

https://gerrit.wikimedia.org/r/488908

Mvolz updated the task description. (Show Details)Feb 7 2019, 11:42 AM

Change 489910 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/services/mathoid@master] Eliminate mocha-eslint

https://gerrit.wikimedia.org/r/489910

Change 489910 merged by Mobrovac:
[mediawiki/services/mathoid@master] Eliminate mocha-eslint

https://gerrit.wikimedia.org/r/489910

• Pchelolo updated the task description. (Show Details)Feb 12 2019, 6:56 PM

• Pchelolo updated the task description. (Show Details)

• Pchelolo updated the task description. (Show Details)Feb 12 2019, 7:02 PM

Change 492357 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/services/recommendation-api@master] Replace istanbul with nyc

https://gerrit.wikimedia.org/r/492357

• bmansurov mentioned this in rMSRAc5e269a74ffa: Replace istanbul with nyc.Feb 22 2019, 6:05 PM

• bmansurov mentioned this in rMSRA48dffd3912b6: Replace istanbul with nyc.Feb 22 2019, 6:47 PM

Change 492357 merged by jenkins-bot:
[mediawiki/services/recommendation-api@master] Replace istanbul with nyc

https://gerrit.wikimedia.org/r/492357

• bmansurov updated the task description. (Show Details)Feb 22 2019, 7:29 PM

• mobrovac mentioned this in T212722: eslint-config-node-services has unmeet peer dependencies.Mar 15 2019, 5:07 PM

• mobrovac merged a task: T212722: eslint-config-node-services has unmeet peer dependencies.

• mobrovac added a subtask: T218386: Invalid peer dependencies between eslint and plugins.

• mobrovac added subscribers: Physikerwelt, • mobrovac, • Clarakosi.

• mobrovac closed subtask T218386: Invalid peer dependencies between eslint and plugins as Resolved.Mar 15 2019, 9:17 PM

• Pchelolo edited projects, added Platform Engineering (Needs Cleaning - Services Operations); removed Patch-For-Review, Platform Team Legacy (Later), Services (later).Jul 17 2019, 5:00 PM