Page MenuHomePhabricator

Update Debian Package for Scap to 3.8.10-1
Closed, ResolvedPublic

Description

The release branch for scap has tags for 3.8.10-1.

Instructions available on Wikitech.

There is 1 important change here.

scap (3.8.10-1) unstable; urgency=low

  * sync-wikiversions - don't do shell expansion

 -- Tyler Cipriani <tcipriani@wikimedia.org>  Tue, 27 Nov 2018 11:40:31 -0700

Event Timeline

thcipriani created this task.

Change 475920 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/puppet@production] Scap: upgrade to 3.8.9-1

https://gerrit.wikimedia.org/r/475920

Adding @fgiunchedi since he usually has the honor of doing scap updates :)

Change 475920 merged by Filippo Giunchedi:
[operations/puppet@production] Scap: upgrade to 3.8.9-1

https://gerrit.wikimedia.org/r/475920

Change 476082 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/puppet@production] Scap: upgrade to 3.8.10-1

https://gerrit.wikimedia.org/r/476082

I checked the command run by sync-wikiversions after the package was updated, and that looked correct; however, I now realize that the shell expansion in that command isn't happening.

That is, the old problem was that //wikiversions*.{json,php} was being included in the rsync command. I've corrected the multiple beginning //; however, the {json,php}, while it works in a shell, does not work in subprocess.

I've tagged debian/3.8.10-1 that should be released (or we can rollback to 3.8.7-1 (previous version)) to ensure that sync-wikiversions works correctly.

thcipriani renamed this task from Update Debian Package for Scap to 3.8.9-1 to Update Debian Package for Scap to 3.8.10-1.Nov 27 2018, 6:51 PM
thcipriani updated the task description. (Show Details)

Change 476082 merged by Cwhite:
[operations/puppet@production] Scap: upgrade to 3.8.10-1

https://gerrit.wikimedia.org/r/476082

thcipriani reassigned this task from thcipriani to colewhite.
thcipriani added a subscriber: colewhite.

thanks @fgiunchedi for the initial 3.8.9-1 release (sorry for missing initial problems)

thanks @colewhite for the quick rebuild and deploy of scap 3.8.10-1!