Page MenuHomePhabricator
Create Task
Maniphest T210487

Navigation controls are out of place in the Notification page
Closed, ResolvedPublic
Actions

Description

Controls to move to the previous and next page of results from the Notifications page used to be placed one next to the other. However, a regression affected them and they are one on top of the other now:

Screen Shot 2018-11-27 at 11.27.09.png (225×1 px, 33 KB)

This looks broken since the layout does not help to convey their expected functionality, breaks the alignment with the other controls provided and invades the content area.

Another breakage from T112982: OOUI ButtonSelectWidget/ButtonGroupWidget not fluid - breaks surveys with multiple buttons and its patch a8ef5fe765c1.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Echowmf/1.33.0-wmf.6+4 -0Fix navigation controls wrapping on Notifications page
mediawiki/extensions/Echomaster+4 -0Fix navigation controls wrapping on Notifications page
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Nov 27 2018, 10:32 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 27 2018, 10:32 AM
kostajh moved this task from Inbox to Needs Discussion/Analysis on the Growth-Team board.Nov 27 2018, 2:35 PM
Etonkovidova assigned this task to Volker_E.Nov 27 2018, 5:22 PM
Volker_E updated the task description. (Show Details)Nov 27 2018, 5:29 PM
gerritbot added a subscriber: gerritbot.Nov 27 2018, 5:29 PM

Change 476063 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Fix navigation controls wrapping on Notifications page

https://gerrit.wikimedia.org/r/476063

gerritbot added a project: Patch-For-Review.Nov 27 2018, 5:29 PM
gerritbot added a comment.Nov 27 2018, 6:17 PM

Change 476063 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix navigation controls wrapping on Notifications page

https://gerrit.wikimedia.org/r/476063

Etonkovidova closed this task as Resolved.Nov 27 2018, 6:49 PM
Etonkovidova added a subscriber: Etonkovidova.

Checked the fix in betalabs - the fix in place.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Nov 27 2018, 7:00 PM
gerritbot added a comment.Dec 3 2018, 7:03 PM

Change 477325 had a related patch set uploaded (by Catrope; owner: VolkerE):
[mediawiki/extensions/Echo@wmf/1.33.0-wmf.6] Fix navigation controls wrapping on Notifications page

https://gerrit.wikimedia.org/r/477325

gerritbot added a comment.Dec 3 2018, 7:16 PM

Change 477325 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.33.0-wmf.6] Fix navigation controls wrapping on Notifications page

https://gerrit.wikimedia.org/r/477325

Stashbot added a subscriber: Stashbot.Dec 3 2018, 7:25 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-03T19:25:58Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.6/extensions/Echo/modules/styles/mw.echo.ui.PaginationWidget.less: SWAT T210487 I914b94515 (duration: 00m 47s)

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 3 2018, 8:00 PM
JTannerWMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.Jan 3 2019, 3:40 PM
JTannerWMF moved this task from Incoming to QA on the Growth-Team (Current Sprint) board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL