Page MenuHomePhabricator

JS Linting: Drop `dot-notation` keyword over-ride from all repos; no longer needed
Open, Needs TriagePublic

Description

In dozens and dozens of repos we've got the eslint rules over-ride of "dot-notation": [ "error", { "allowKeywords": true } ].

This dates from when we allowed ES3-only browsers to use our code, with ES5 methods poly-filled as needed. Consequently, any time people used a property named the same as a ES3-future-reserved-but-dropped-in-ES5 keyword, they had to escape it (e.g. foo.super would break an ES3 browser, so one had to use foo['super']). However, we now require ES5-compatible parsing in all browsers, so it's no longer needed.

At this point it's just been cargo-culted around the codebases. Let's burn it with fire.

Gerrit searches:

bug:T210552
bug:T210552 is:open


Initial hit-list from https://codesearch.wmflabs.org/search/?q=dot-notation&i=nope&files=%5C.json%24&repos= :

  • MediaWiki
  • VE standalone
  • OOUI
  • extensions / AdvancedSearch
  • extensions / ArticleCreationWorkflow
  • extensions / BetaFeatures
  • extensions / CentralAuth
  • extensions / Cite
  • extensions / Citoid
  • extensions / CodeEditor
  • extensions / CodeMirror
  • extensions / ContentTranslation
  • extensions / Echo
  • extensions / Flow
  • extensions / Graph
  • extensions / Kartographer
  • extensions / Math
  • extensions / MobileFrontend
  • extensions / MultimediaViewer
  • extensions / Newsletter
  • extensions / PageViewInfo
  • extensions / PerformanceInspector
  • extensions / Popups
  • extensions / ProofreadPage
  • extensions / QuickSurveys
  • extensions / RevisionSlider
  • extensions / Score
  • extensions / SyntaxHighlight_GeSHi
  • extensions / TemplateData
  • extensions / TemplateWizard
  • extensions / TwoColConflict
  • extensions / UniversalLanguageSelector
  • extensions / UploadWizard
  • extensions / VisualEditor
  • extensions / Wikibase
  • extensions / WikibaseMediaInfo
  • extensions / WikibaseQualityConstraints
  • extensions / WikiEditor
  • extensions / wikihiero
  • skins / MinervaNeue

Details

Related Gerrit Patches:
mediawiki/extensions/ArticlePlaceholder : mastereslint: Drop 'dot-notation' rule over-ride
mediawiki/extensions/UserAgreement : mastereslint: Drop 'dot-notation' rule over-ride
mediawiki/extensions/Wikisource : mastereslint: Drop 'dot-notation' rule over-ride
mediawiki/extensions/TemplateWizard : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (52b89a9db)
mediawiki/extensions/Math : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/WikibaseQualityConstraints : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/AdvancedSearch : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/MultimediaViewer : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/CentralAuth : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/ArticleCreationWorkflow : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/Graph : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/CodeMirror : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/ContentTranslation : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/Citoid : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/PageViewInfo : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/TemplateData : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/SyntaxHighlight_GeSHi : mastereslint: Drop 'dot-notation' rule
mediawiki/skins/MinervaNeue : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/wikihiero : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/Wikibase : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/WikiEditor : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/Kartographer : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/UniversalLanguageSelector : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/QuickSurveys : mastereslint: Drop 'dot-notation' rule over-ride
mediawiki/extensions/MobileFrontend : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/RevisionSlider : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/WikibaseMediaInfo : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/UploadWizard : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/BetaFeatures : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/TwoColConflict : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/PerformanceInspector : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/ProofreadPage : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/Score : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/CodeEditor : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/Cite : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/Newsletter : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/Flow : mastereslint: Drop 'dot-notation' rule
oojs/ui : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/Echo : mastereslint: Drop 'dot-notation' rule
mediawiki/extensions/VisualEditor : mastereslint: Drop 'dot-notation' rule
mediawiki/core : mastereslint: Drop 'dot-notation' rule
VisualEditor/VisualEditor : mastereslint: Drop 'dot-notation' rule

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 476325 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/BetaFeatures@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476325

Change 476326 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CentralAuth@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476326

Change 476328 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Cite@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476328

Change 476329 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Citoid@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476329

Change 476331 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CodeEditor@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476331

Change 476332 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CodeMirror@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476332

Change 476333 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/ContentTranslation@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476333

Change 476336 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Graph@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476336

Change 476337 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Kartographer@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476337

Change 476339 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Math@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476339

Change 476340 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/MultimediaViewer@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476340

Change 476341 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Newsletter@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476341

Change 476344 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/PageViewInfo@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476344

Change 476346 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/PerformanceInspector@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476346

Change 476347 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/ProofreadPage@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476347

Change 476341 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476341

Change 476348 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/QuickSurveys@master] eslint: Drop 'dot-notation' rule over-ride

https://gerrit.wikimedia.org/r/476348

Change 476349 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/RevisionSlider@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476349

Change 476350 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476350

Change 476351 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Score@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476351

Change 476353 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TemplateData@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476353

Change 476354 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TemplateWizard@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476354

Change 476355 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/UploadWizard@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476355

Change 476356 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TwoColConflict@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476356

Change 476357 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/UniversalLanguageSelector@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476357

Change 476328 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476328

Change 476331 merged by jenkins-bot:
[mediawiki/extensions/CodeEditor@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476331

Change 476359 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Wikibase@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476359

Change 476362 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476362

Change 476363 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseQualityConstraints@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476363

Change 476364 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikiEditor@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476364

Change 476365 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/wikihiero@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476365

Change 476367 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/skins/MinervaNeue@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476367

Change 476347 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476347

Change 476351 merged by jenkins-bot:
[mediawiki/extensions/Score@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476351

Change 476346 merged by jenkins-bot:
[mediawiki/extensions/PerformanceInspector@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476346

Change 476356 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476356

Change 476325 merged by jenkins-bot:
[mediawiki/extensions/BetaFeatures@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476325

Change 476355 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476355

Change 476362 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476362

Change 476349 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476349

Change 476254 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476254

Change 476357 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476357

Change 476348 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] eslint: Drop 'dot-notation' rule over-ride

https://gerrit.wikimedia.org/r/476348

Change 476337 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476337

Change 476359 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476359

Change 476364 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476364

Change 476367 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476367

Change 476365 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476365

Change 476350 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476350

Change 476353 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476353

Change 476344 merged by jenkins-bot:
[mediawiki/extensions/PageViewInfo@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476344

Change 476333 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476333

Change 476336 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476336

Change 476332 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476332

Change 476329 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476329

Change 476326 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476326

Change 476321 merged by jenkins-bot:
[mediawiki/extensions/ArticleCreationWorkflow@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476321

Change 476340 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476340

Change 476320 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476320

Change 476363 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476363

Change 476339 merged by jenkins-bot:
[mediawiki/extensions/Math@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476339

Jdforrester-WMF updated the task description. (Show Details)

Only remaining repo to fix is Page-Previews, but the totally non-standard code there breaks every tool I have, so someone from Readers-Web-Backlog will have to take a look.

Change 476999 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (52b89a9db)

https://gerrit.wikimedia.org/r/476999

Change 476999 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (52b89a9db)

https://gerrit.wikimedia.org/r/476999

Change 476354 merged by Umherirrender:
[mediawiki/extensions/TemplateWizard@master] eslint: Drop 'dot-notation' rule

https://gerrit.wikimedia.org/r/476354

DannyS712 updated the task description. (Show Details)Mon, Nov 18, 10:59 AM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMon, Nov 18, 10:59 AM
Jdforrester-WMF reopened this task as Open.Mon, Nov 18, 2:01 PM

I still see it in a few places: https://codesearch.wmflabs.org/search/?q=%22dot-notation%22&i=nope&files=&repos=

  • ArticlePlaceholder
  • PageForms
  • UserAgreement
  • Wikisource

… plus some non-gerrit repos.

I still see it in a few places: https://codesearch.wmflabs.org/search/?q=%22dot-notation%22&i=nope&files=&repos=

  • ArticlePlaceholder
  • PageForms
  • UserAgreement
  • Wikisource

… plus some non-gerrit repos.

Other than wikisource, the configuration does not match the over-ride that needs to be removed (per task description)

Change 553789 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikisource@master] eslint: Drop 'dot-notation' rule over-ride

https://gerrit.wikimedia.org/r/553789

Change 553789 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] eslint: Drop 'dot-notation' rule over-ride

https://gerrit.wikimedia.org/r/553789

Change 554166 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/ArticlePlaceholder@master] eslint: Drop 'dot-notation' rule over-ride

https://gerrit.wikimedia.org/r/554166

Change 554167 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/UserAgreement@master] eslint: Drop 'dot-notation' rule over-ride

https://gerrit.wikimedia.org/r/554167

Change 554166 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] eslint: Drop 'dot-notation' rule over-ride

https://gerrit.wikimedia.org/r/554166