Page MenuHomePhabricator

Deploy page issues to all wikipedias (except enwiki)
Closed, ResolvedPublic2 Story Points

Description

NOTE: this is currently scheduled for December 17, 2018

Background

We will be deploying the page issues feature to all wikipedias but enwiki (due to annual fundraiser). The changes to page issue warnings will only appear on certain ambox templates and the visual design may vary based on the templates used on the local wikis.

Acceptance criteria

  • Ensure all direct subtasks are resolved
  • Deploy the page issues feature to 100% of users on all wikipedias except enwiki

Developer notes

$wgMinervaPageIssuesNewTreatment = [
        "base" => true,
        "beta" => true,
];

Related Objects

StatusAssignedTask
OpenNirzar
Resolved Jdlrobson
Resolvedovasileva
Resolvedalexhollender
OpenNone
Resolvedphuedx
Resolved Tbayer
Resolvedovasileva
ResolvedNiedzielski
Resolved Tbayer
Resolved Tbayer
Resolved Tbayer
Resolved Tbayer
Resolvedovasileva
Resolved Tbayer
Resolvedphuedx
Resolvedovasileva
Resolved Jdlrobson
Resolved Jdlrobson
Resolved Tbayer
Resolved Tbayer
ResolvedNiedzielski
DeclinedNone
Resolvedovasileva
DuplicateNone
ResolvedNiedzielski

Event Timeline

ovasileva triaged this task as Normal priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 27 2018, 10:17 PM
ovasileva renamed this task from Deploy page issues to all wikis but enwiki to Deploy page issues to all wikis (except enwiki).
ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)
ovasileva raised the priority of this task from Normal to High.Dec 4 2018, 5:05 PM
ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)Dec 4 2018, 5:18 PM
phuedx added a subscriber: pmiazga.Dec 4 2018, 5:22 PM

@pmiazga also points out that $wgMinervaPageIssuesNewTreatment = true; needs to be set everywhere too (unless it already is 🤔).

ovasileva set the point value for this task to 2.Dec 4 2018, 5:22 PM
Jdlrobson added a subscriber: Jdlrobson.
Ensure all subtasks are resolved (except T202349 and T204143

T211257 and T200794 remain unresolved so this is blocked on those.

phuedx updated the task description. (Show Details)Dec 17 2018, 11:33 AM
ovasileva renamed this task from Deploy page issues to all wikis (except enwiki) to Deploy page issues to all wikipedias (except enwiki).Dec 17 2018, 6:09 PM
ovasileva updated the task description. (Show Details)
nray reassigned this task from nray to Jdlrobson.Dec 17 2018, 6:11 PM
nray added a subscriber: nray.

Change 480127 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Page issues treatment enabled on all wikis except enwiki

https://gerrit.wikimedia.org/r/480127

Scheduled for 40 minutes from now

Restricted Application added a subscriber: Dereckson. · View Herald TranscriptDec 17 2018, 6:22 PM

Change 480127 merged by jenkins-bot:
[operations/mediawiki-config@master] Page issues treatment enabled on all wikis except enwiki

https://gerrit.wikimedia.org/r/480127

Mentioned in SAL (#wikimedia-operations) [2018-12-17T19:27:58Z] <pmiazga@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:480127 | Page issues treatment enabled on all wikis except enwiki(T210553)]] (duration: 00m 45s)

languagesingle issuesection issuemultiple issuesnotes
Spanishworking as expected:
link
working as expected:
link
working as expected:
link
.
Germanno changeno changeno change...
Japaneseworking as expected
link
working as expected
link
working as expected
link
...
Frenchslight FOUC
link
working as expected
link
working as expected
link
...
languagesingle issuesection issuemultiple issuesnotes
Russianslight FOUC
link
working as expected
link
slight FOUC
link
...
Italianno changeno changeno change...
Chineseworking as expected
link
working as expected:
link
working as expected
link
...
Portugueseworking as expected
link
working as expected
link
working as expected
link
...
Polishworking as expected
link
working as expected
link
working as expected
link
...

looks good! I am however getting a slight FOUC on some wikis (in particular frwiki and ruwiki)

pmiazga updated the task description. (Show Details)
ovasileva added a subscriber: alexhollender.

moving this to signoff. Since I QA'd it, perhaps @alexhollender might be a good person to do signoff.

@ovasileva sounds good, will do signoff today