Page MenuHomePhabricator
Create Task
Maniphest T210670

Regression: UI broken in search overlay, image, VE and language overlays
Closed, ResolvedPublic
Actions

Description

Searching is suffering from various UI regressions. While usable, there are problems with the spinner showing when it shouldn't and the search in pages feature being squished:

UBN.gif (501×1 px, 150 KB)

There are similar breakages in the media viewer:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein#/media/File%3AEinstein_1921_by_F_Schmutzer_-_restoration.jpg

and minor breakages in the languages overlay and visual editor overlay (T210640):

Screen Shot 2018-11-28 at 1.38.02 PM.png (450×1 px, 17 KB)

Post morterm

The regressions were due to some problems in the inheritance chain which meant the incorrect class on Overlays was being set. I've documented them in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/476404 Overlays should respect inheritance chain when passing up options

This did not make the train so no SWATs are needed

QA steps

We should visit every single possible overlay in mobile and verify that nothing looks odd about them. Please test this on the BETA CLUSTER
Ideally this should happen after the completion of T209007

The overlays to check are

Details

SubjectRepoBranchLines +/-
Pass isBorderbox and className properties as optionsmediawiki/extensions/MobileFrontendmaster+81 -102
Prepare View's for option usage rather than class propertymediawiki/extensions/MobileFrontendmaster+108 -35
Overlays should respect inheritance chain when passing up optionsmediawiki/extensions/MobileFrontendmaster+22 -16
Revert "Several View's now pass className and isBorderBox as a property"mediawiki/extensions/MobileFrontendmaster+68 -48
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Nov 28 2018, 9:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2018, 9:19 PM
Jdlrobson triaged this task as Unbreak Now! priority.Nov 28 2018, 9:19 PM

I can replicate on beta cluster and locally

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptNov 28 2018, 9:19 PM
gerritbot subscribed.Nov 28 2018, 9:27 PM

Change 476397 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Revert "Several View's now pass className and isBorderBox as a property"

https://gerrit.wikimedia.org/r/476397

gerritbot added a project: Patch-For-Review.Nov 28 2018, 9:27 PM
Jdlrobson renamed this task from Regression: UI broken in search overlay to Regression: UI broken in search overlay, ImageOverlay.Nov 28 2018, 9:37 PM
Jdlrobson renamed this task from Regression: UI broken in search overlay, ImageOverlay to Regression: UI broken in search overlay, image and language overlays.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Nov 28 2018, 9:49 PM

Change 476404 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Overlays should respect inheritance chain when passing up options

https://gerrit.wikimedia.org/r/476404

gerritbot added a comment.Nov 28 2018, 11:10 PM

Change 476397 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Revert "Several View's now pass className and isBorderBox as a property"

https://gerrit.wikimedia.org/r/476397

gerritbot added a comment.Nov 28 2018, 11:28 PM

Change 476404 abandoned by Jdlrobson:
Overlays should respect inheritance chain when passing up options

https://gerrit.wikimedia.org/r/476404

Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.Nov 28 2018, 11:30 PM
Jdlrobson moved this task from To Do to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

The regressions were due to some problems in the inheritance chain. I've documented them in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/476404 Overlays should respect inheritance chain when passing up options

This did not make the train so no SWATs are needed.

gerritbot added a comment.Nov 28 2018, 11:37 PM

Change 476426 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Prepare View's for option usage rather than class property

https://gerrit.wikimedia.org/r/476426

gerritbot added a comment.Nov 28 2018, 11:39 PM

Change 476423 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Revert "Revert "Several View's now pass className and isBorderBox as a property""

https://gerrit.wikimedia.org/r/476423

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Nov 29 2018, 12:01 AM
Jdlrobson renamed this task from Regression: UI broken in search overlay, image and language overlays to Regression: UI broken in search overlay, image, VE and language overlays.Nov 29 2018, 5:36 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson merged a task: T210640: Regression: Double border in mobile VE.
Jdlrobson added subscribers: Esanders, matmarex.
Jdlrobson mentioned this in T210557: Wikimedia\Rdbms\LoadBalancer::pickReaderIndex: all replica DBs lagged. Switch to read-only mode.Nov 29 2018, 6:51 PM
Jdlrobson assigned this task to ABorbaWMF.Nov 29 2018, 7:09 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs QA to Blocked on Others on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 30 2018, 7:36 PM
gerritbot added a comment.Dec 5 2018, 7:19 PM

Change 476426 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Prepare View's for option usage rather than class property

https://gerrit.wikimedia.org/r/476426

matmarex added a project: MobileFrontend.Dec 5 2018, 8:58 PM
gerritbot added a comment.Dec 11 2018, 12:30 AM

Change 476423 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Pass isBorderbox and className properties as options

https://gerrit.wikimedia.org/r/476423

Jdlrobson claimed this task.Dec 12 2018, 6:17 PM
Jdlrobson moved this task from Blocked on Others to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Jdlrobson added a subscriber: ABorbaWMF.

I can do generalQA on this as part of my other QA tasks.

Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 12 2018, 8:41 PM
Jdlrobson closed this task as Resolved.Dec 12 2018, 8:46 PM
Jdlrobson updated the task description. (Show Details)

Not seeing any problems. Checked all overlays on beta cluster. All display.
While testing I noticed that I'm not seeing any notifications on the beta cluster. Have reached out to a few people to check that is isolated to me or a known issue.

Liuxinyu970226 unsubscribed.Dec 16 2018, 1:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits