Center aligned map does not really look center aligned on mobile VE
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ryasmeen
	Nov 28 2018, 10:33 PM

Description

Steps to replicate:

Insert a map using mobile VE
Change the alignment of the map to be centre aligned

Observe that the map is not really at the center of the page. The blue highlight covering it also seems to be extended towards the right side of the page.

Screen Shot 2018-11-28 at 2.28.50 PM.png (639×1 px, 188 KB)

This is observed on both desktop and mobile browsers.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ve.ce.MWMapsNode: Set CSS width on <div class="thumbinner"> too	mediawiki/extensions/Kartographer	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: T203473: Fix maps dialog in mobile visual editor

Event Timeline

Ryasmeen created this task.Nov 28 2018, 10:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2018, 10:33 PM

Ryasmeen mentioned this in T203473: Fix maps dialog in mobile visual editor .Nov 28 2018, 10:51 PM

Hmm, it looks a bit broken on desktop too.

View mode:

Edit mode:

matmarex edited projects, added Maps (Kartographer), VisualEditor-MediaWiki, VisualEditor (Current work); removed VisualEditor.Nov 29 2018, 11:48 PM

Change 476785 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Kartographer@master] ve.ce.MWMapsNode: Set CSS width on <div class="thumbinner"> too

https://gerrit.wikimedia.org/r/476785

gerritbot added a project: Patch-For-Review.Nov 29 2018, 11:56 PM

After:

Desktop
Mobile

Esanders moved this task from Incoming to QA on the VisualEditor (Current work) board.Nov 30 2018, 2:04 PM

Change 476785 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] ve.ce.MWMapsNode: Set CSS width on <div class="thumbinner"> too

https://gerrit.wikimedia.org/r/476785

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Nov 30 2018, 3:01 PM

MSantos moved this task from Unsorted to Tracking on the Maps (Kartographer) board.Dec 4 2018, 3:44 PM

Ryasmeen added a project: Editing QA.Dec 11 2018, 10:29 PM

Esanders moved this task from Inbox to Low Priority on the Editing QA board.Dec 13 2018, 4:04 PM

Ryasmeen added a project: Verified.Dec 13 2018, 11:25 PM

Ryasmeen removed projects: Editing QA, Patch-For-Review.

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• marcella closed this task as Resolved.Dec 19 2018, 2:53 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 19 2018, 2:53 PM

	F27322986: Screen Shot 2018-11-28 at 2.28.50 PM.png
	Nov 28 2018, 10:33 PM

Center aligned map does not really look center aligned on mobile VEClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Center aligned map does not really look center aligned on mobile VE
Closed, ResolvedPublic
Actions