Page MenuHomePhabricator
Create Task
Maniphest T210847

Resize the OOUI 'x` close icon?
Closed, ResolvedPublic
Actions

Description

There's not a single application where the 20x20px close icon is a good fit IMHO:
Current treatment with 20x20px filling canvas

image.png (150×1 px, 30 KB)

Override in Popups to 16x16px

image.png (334×750 px, 22 KB)

We should think if deriving from our own guidelines would make sense in this case or if we want to add another icon…

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.30.1mediawiki/coremaster+454 -332
icons: Decrease 'close' size marginallyoojs/uimaster+2 -2
Customize query in gerrit

Event Timeline

Volker_E created this task.Nov 30 2018, 3:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2018, 3:34 PM
Volker_E updated the task description. (Show Details)Nov 30 2018, 3:37 PM
Jdforrester-WMF subscribed.Nov 30 2018, 6:35 PM

Going for 16x16 seems great.

Volker_E added a comment.Dec 1 2018, 9:21 PM
In T210847#4789766, @Jdforrester-WMF wrote:

Going for 16x16 seems great.

Yes, that was my first thought too. We derive from the standard size in the 'add' icon already which seems like a similar case.

Volker_E added a subscriber: RHo.Dec 19 2018, 4:42 AM

@RHo Any feelings about this? I've just looked at the Personalized First Day implementation again and had the same reaction about 20x20px being too large that made me file this.

RHo added a comment.Jan 2 2019, 1:08 PM
In T210847#4833314, @Volker_E wrote:

@RHo Any feelings about this? I've just looked at the Personalized First Day implementation again and had the same reaction about 20x20px being too large that made me file this.

Sure, 16x16px seems to work well.

gerritbot subscribed.Jan 8 2019, 4:07 AM

Change 482756 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Decrease 'close' size marginally

https://gerrit.wikimedia.org/r/482756

gerritbot added a project: Patch-For-Review.Jan 8 2019, 4:07 AM
Volker_E triaged this task as Low priority.Jan 8 2019, 4:07 AM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.
Volker_E added a comment.EditedJan 8 2019, 4:43 PM

@RHo Should we make a note in icon page or remain silent about this special case?

RHo added a comment.Jan 8 2019, 5:00 PM

I think we don't need to mention this one exception case

Esanders subscribed.Jan 8 2019, 5:42 PM

you should probably leave a link to this bug in the code, to prevent someone from "fixing" this in future

gerritbot added a comment.Jan 8 2019, 5:50 PM

Change 482756 merged by jenkins-bot:
[oojs/ui@master] icons: Decrease 'close' size marginally

https://gerrit.wikimedia.org/r/482756

Volker_E closed this task as Resolved.Jan 8 2019, 6:54 PM
Volker_E claimed this task.
Volker_E moved this task from Reviewing to OOUI-0.30.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.30.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
gerritbot added a comment.Jan 11 2019, 4:20 PM

Change 483796 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.1

https://gerrit.wikimedia.org/r/483796

gerritbot added a project: Patch-For-Review.Jan 11 2019, 4:20 PM
gerritbot added a comment.Jan 11 2019, 5:28 PM

Change 483796 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.1

https://gerrit.wikimedia.org/r/483796

Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.13; 2019-01-15); removed Patch-For-Review.Jan 11 2019, 7:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL