[SWAT] Regression: Table of contents is empty
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Niedzielski
	Nov 30 2018, 6:47 PM

Description

FIX should be SWATed at earliest opportunity

Steps to Reproduce

Visit https://en.m.wikipedia.org/wiki/Dog or https://en.m.wikipedia.org/wiki/Cat on the Minerva mobile site
Tap the contents button

Expected Results

Article table of contents is shown

Actual Results

Drop down expands but no content is shown

en.m.wikipedia.org_wiki_Dog(iPad Pro) (1).png (2×2 px, 1 MB)

en.m.wikipedia.org_wiki_Cat(iPad Pro).png (2×2 px, 988 KB)

Environments Observed

enwiki

Browser Version

Chromium v70.0.3538.77

OS Version

Ubuntu v18.10

Device Model

Desktop

Device Language

English

Developer notes

Broken by Idca3c733ad184365877f37ff9f919fb1b188fa7b (T209007)

Details

	Subject	Repo	Branch	Lines +/-
	TableOfContents has a section prop	mediawiki/extensions/MobileFrontend	wmf/1.33.0-wmf.6	+6 -3
	TableOfContents has a section prop	mediawiki/extensions/MobileFrontend	master	+6 -3

Customize query in gerrit

Related Objects

Mentioned Here: T209007: MFA: View: Make isBorderBox and className passable options to the View class to reduce reliance on inheritance

Event Timeline

• Niedzielski created this task.Nov 30 2018, 6:47 PM

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptNov 30 2018, 6:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson raised the priority of this task from Medium to High.Nov 30 2018, 7:18 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.

Change 476910 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] TableOfContents has a section prop

https://gerrit.wikimedia.org/r/476910

gerritbot added a project: Patch-For-Review.Nov 30 2018, 7:24 PM

Patch is up. Will leave in your capable hands. Let's check with @ovasileva whether this needs SWATing on Monday.

In T210869#4789909, @Jdlrobson wrote:

Patch is up. Will leave in your capable hands. Let's check with @ovasileva whether this needs SWATing on Monday.

@Jdlrobson - yes please, if possible.

Jdlrobson renamed this task from [Bug] Table of contents is empty to [SWAT}[Bug] Table of contents is empty.Nov 30 2018, 7:42 PM

Jdlrobson renamed this task from [SWAT}[Bug] Table of contents is empty to [SWAT] Regression: Table of contents is empty.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Regression.

Change 476913 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.6] TableOfContents has a section prop

https://gerrit.wikimedia.org/r/476913

Change 476910 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] TableOfContents has a section prop

https://gerrit.wikimedia.org/r/476910

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Nov 30 2018, 9:00 PM

• Niedzielski claimed this task.Dec 3 2018, 6:08 PM

Change 476913 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.6] TableOfContents has a section prop

https://gerrit.wikimedia.org/r/476913

SWATed.

Mentioned in SAL (#wikimedia-operations) [2018-12-03T19:39:12Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.6/extensions/MobileFrontend/resources/mobile.toc/TableOfContents.js: SWAT T210869 Fix Table of contents rendering (duration: 00m 47s)

\o/ thank you, @Jdforrester-WMF! I see these changes live now and working properly.

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 3 2018, 8:00 PM

	F27335528: en.m.wikipedia.org_wiki_Cat(iPad Pro).png
	Nov 30 2018, 6:47 PM

	F27335535: en.m.wikipedia.org_wiki_Dog(iPad Pro) (1).png
	Nov 30 2018, 6:47 PM

[SWAT] Regression: Table of contents is emptyClosed, ResolvedPublicActions