[SWAT] Regression: Table of contents is empty
Closed, ResolvedPublic

Description

FIX should be SWATed at earliest opportunity

Steps to Reproduce

  1. Visit https://en.m.wikipedia.org/wiki/Dog or https://en.m.wikipedia.org/wiki/Cat on the Minerva mobile site
  2. Tap the contents button

Expected Results

  • Article table of contents is shown

Actual Results

  • Drop down expands but no content is shown

Environments Observed

  • enwiki

Browser Version

  • Chromium v70.0.3538.77

OS Version

  • Ubuntu v18.10

Device Model

  • Desktop

Device Language

  • English

Developer notes

Broken by Idca3c733ad184365877f37ff9f919fb1b188fa7b (T209007)

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptFri, Nov 30, 6:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson raised the priority of this task from Normal to High.Fri, Nov 30, 7:18 PM
Jdlrobson updated the task description. (Show Details)

Change 476910 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] TableOfContents has a section prop

https://gerrit.wikimedia.org/r/476910

Jdlrobson added subscribers: ovasileva, Jdlrobson.

Patch is up. Will leave in your capable hands. Let's check with @ovasileva whether this needs SWATing on Monday.

Patch is up. Will leave in your capable hands. Let's check with @ovasileva whether this needs SWATing on Monday.

@Jdlrobson - yes please, if possible.

Jdlrobson renamed this task from [Bug] Table of contents is empty to [SWAT}[Bug] Table of contents is empty.Fri, Nov 30, 7:42 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from [SWAT}[Bug] Table of contents is empty to [SWAT] Regression: Table of contents is empty.
Jdlrobson added a project: Regression.

Change 476913 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.6] TableOfContents has a section prop

https://gerrit.wikimedia.org/r/476913

Change 476910 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] TableOfContents has a section prop

https://gerrit.wikimedia.org/r/476910

Change 476913 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.6] TableOfContents has a section prop

https://gerrit.wikimedia.org/r/476913

Mentioned in SAL (#wikimedia-operations) [2018-12-03T19:39:12Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.6/extensions/MobileFrontend/resources/mobile.toc/TableOfContents.js: SWAT T210869 Fix Table of contents rendering (duration: 00m 47s)

Niedzielski closed this task as Resolved.Mon, Dec 3, 7:45 PM

\o/ thank you, @Jdforrester-WMF! I see these changes live now and working properly.