Page MenuHomePhabricator

Multilingual Captions: When user updates their babel settings, change is not reflected on pages until logout
Open, LowestPublic

Description

In T209864, updates were made to the caption code to have Commons work similarly to Wikidata for Babel interaction. In terms of language display order, this work seems complete.

However, one remaining (low priority) issue is that when the user updates the babel template on their user page, on the Federated-Commons labs instance at least, the user must log out and log in again before those changes are reflected in the caption UI. On Wikidata, changes to the template take effect immediately.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2018, 7:45 PM
Ramsey-WMF triaged this task as Low priority.Nov 30 2018, 7:46 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptNov 30 2018, 7:46 PM
Ramsey-WMF assigned this task to Cparle.Nov 30 2018, 7:46 PM
Ramsey-WMF lowered the priority of this task from Low to Lowest.

Tentatively assigning to Cormac although this is very, very low priority at the moment.

Ramsey-WMF moved this task from Untriaged to Triaged on the Multimedia board.Nov 30 2018, 7:48 PM
Ramsey-WMF reassigned this task from Cparle to egardner.Mar 4 2019, 5:47 PM
Ramsey-WMF added a subscriber: Cparle.
egardner added a comment.EditedMar 7 2019, 12:09 AM

I assume the time to check for the most current state of the user's babel settings is in one of the extension's hooks, in PHP. onBeforePageDisplay maybe? This seems to be when the babel lookup is happening currently.

Honestly I don't understand much of what is happening in this method – my PHP knowledge remains pretty sketchy and the code here seems fairly complex. Still happy to work on this ticket but I think I will need some help understanding what is going on here before I can do much.

Ha78na moved this task from Triaged to Next up on the Multimedia board.Mar 8 2019, 5:26 PM
egardner removed egardner as the assignee of this task.Mar 25 2019, 4:54 PM
egardner added a subscriber: egardner.