Page MenuHomePhabricator

WikiLove: duplicate messages delivered
Open, Needs TriagePublic

Description

Steps to reproduce:
on Flow pages (reproducible in betalabs)

  1. Open WikiLove (click heart icon) and pick a kitty to send. Type a message.
  2. Use the X in the corner of the box to close it.
  3. Open WikiLove again (click heart icon again).
  4. Preview.
  5. Send.

Actual results:
Two identical messages posted.

Expected results:
One message sent.

Extra fun:
Double-click the Send button in step 5. Then you can send four kitties.

On wikitext User talk pages, the steps are as above, but the Send button must be double-clicked.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Re-checking in betalabs:
(1) Following the steps in the task description - I did not manage to sent multiple WikiLove messages.
(2) Clicking multiple times on the Send button - the duplicate messages were sent (but no more than two).
(3) The error was displayed

Screen Shot 2019-06-12 at 3.59.22 PM.png (525×1 px, 286 KB)

(1) Following the steps in the task description - I did not manage to sent multiple WikiLove messages.

I was able to send duplicate messages on Mediawiki.org (structured discussions). Maybe it's specific to Flow?

MMiller_WMF renamed this task from Duplicate messages delivered to WikiLove: duplicate messages delivered.Jul 3 2019, 4:56 PM
MMiller_WMF added subscribers: Catrope, SBisson, Trizek-WMF.

(1) Following the steps in the task description - I did not manage to sent multiple WikiLove messages.

I was able to send duplicate messages on Mediawiki.org (structured discussions). Maybe it's specific to Flow?

I checked ukwiki in betalabs where Flow is not installed. Duplicate WikiLove messages can be sent as described in the task and in the steps in my comment.

Hey @Etonkovidova it is unclear when and why this happens in order to enable us to determine the urgency of this task. Can you evaluate when and why this is happening?

I re-checked the issue in betalabs. The issue with sending duplicate WikiLove messages is different on Flow-based User talk pages and wikitext User talk pages. I've update the task description and also will summarize it here:

Flow-based pages - the steps exactly as described in the task description.
wikitext-based pages - duplicates will be sent with double-clicked Send button only. The steps #2-3 may be omitted.

The Growth-Team figured out what the specific issues are here, we are not going to work on it but it is still a good first bug that someone else should work on.