Page MenuHomePhabricator
Create Task
Maniphest T210914

Valid input in TagMultiselectWidget flagged as invalid on Special:ApiSandbox
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Go to https://en.wikipedia.org/wiki/Special:ApiSandbox.
  2. Select action=query, change to that page.
  3. Enable prop, type "c", select "categories" from the list.

Alternatively, in step 3 you can type "categories" and press enter, without using the list.

Expected: Input is valid, so it shouldn't be flagged.
Actual: Border and cursor are red, indicating an invalid input.

Removing the focus from the input fixes the display (until the next time you enter something via keyboard), but shouldn't be necessary.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+266 -98Update OOUI to v0.30.0
oojs/uimaster+2 -2OO.ui.MenuTagMultiselectWidget: Clear input before adding tag
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Dec 1 2018, 10:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2018, 10:27 AM
Anomie removed a project: MediaWiki-Action-API.Dec 3 2018, 2:47 PM
Anomie added a subscriber: Anomie.

Nothing to do with the API here, it affects any use of TagMultiselectWidget with a list of allowed values. In core I see Special:ActiveUsers is also affected.

matmarex added a subscriber: matmarex.Dec 4 2018, 4:24 AM

It's not just invalid, it's a weird semi-valid semi-invalid border. It should never be half red, half blue.

image.png (49×504 px, 2 KB)

Looks similar to T199838: [Regression wmf.13] Input field getting both red and blue highlight at the same time in Citation dialog (not sure if it's actually relevant, but maybe it helps in some debugging).

Schnark added a comment.Dec 4 2018, 8:09 AM

I can see the red-blue border in Vector, but Timeless has a completely red border.

Tchanders added a subscriber: Tchanders.EditedDec 5 2018, 2:51 PM

This is affecting the TitlesMultiselectWidget on Special:Block too (with partial blocks enabled).

gerritbot added a subscriber: gerritbot.Dec 5 2018, 3:03 PM

Change 477792 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] OO.ui.TagMultiselectWidget: Allow empty input to be valid

https://gerrit.wikimedia.org/r/477792

gerritbot added a project: Patch-For-Review.Dec 5 2018, 3:03 PM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Dec 5 2018, 4:07 PM
gerritbot added a comment.Dec 7 2018, 6:31 PM

Change 477792 merged by jenkins-bot:
[oojs/ui@master] OO.ui.MenuTagMultiselectWidget: Clear input before adding tag

https://gerrit.wikimedia.org/r/477792

gerritbot added a comment.Dec 22 2018, 11:37 AM

Change 481239 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

gerritbot added a comment.Dec 24 2018, 1:51 AM

Change 481239 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

Jdforrester-WMF closed this task as Resolved.Jan 1 2019, 4:07 PM
Jdforrester-WMF assigned this task to Tchanders.
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed Patch-For-Review.
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL