Page MenuHomePhabricator
Create Task
Maniphest T210970

Implement eventlogging for Wikidata descriptions editing on iOS app
Closed, ResolvedPublic
Actions

Assigned To
• chelsyx
Authored By
• chelsyx
Dec 3 2018, 6:59 AM
Tags
Referenced Files
F17606225: 02 Wikidata descriptions.png
Feb 6 2019, 9:50 PM
F27382893: IMG_2324.PNG
Dec 4 2018, 9:40 PM
F17606228: 04 Wikidata descriptions.png
Dec 3 2018, 7:53 PM
F27367557: Screen Shot 2018-12-03 at 11.52.33 AM.png
Dec 3 2018, 7:53 PM
F27360527: wikidata edit start.png
Dec 3 2018, 6:59 AM
F17606235: 07 Wikidata descriptions.png
Dec 3 2018, 6:59 AM
F27360859: Screen Shot 2018-12-02 at 10.50.37 PM.png
Dec 3 2018, 6:59 AM
F27360675: Screen Shot 2018-12-02 at 10.24.55 PM.png
Dec 3 2018, 6:59 AM
View All 13 Files
Subscribers
ABorbaWMF
• chelsyx
• JMinor
JoeWalsh
• NHarateh_WMF

Description

As schema MobileWikiAppEdit is already being used for regular editing on the iOS app, we want to adapt it to record Wikidata descriptions editing events. Specifically:

  • Revision: 17837072 -> 18115551
  • Several field names change:
    • sessionToken -> session_token
    • appInstallID -> app_install_id
    • ts -> client_dt
  • Events needs to be recorded for Wikidata descriptions editing:
Start to add new descriptionStart to edit existing descriptionReady to edit (cursor blinking)Attempt to saveSaved successfullyError (if any)
01 Wikidata descriptions.png (1×750 px, 744 KB)
wikidata edit start.png (1×828 px, 239 KB)
04 Wikidata descriptions.png (1×750 px, 120 KB)
05 Wikidata descriptions.png (1×750 px, 128 KB)
07 Wikidata descriptions.png (1×750 px, 331 KB)
IMG_2324.PNG (1×750 px, 110 KB)
Screen Shot 2018-12-02 at 10.24.55 PM.png (216×468 px, 27 KB)
Screen Shot 2018-12-02 at 10.25.55 PM.png (222×471 px, 28 KB)
Screen Shot 2018-12-03 at 11.52.33 AM.png (219×477 px, 27 KB)
Screen Shot 2018-12-02 at 10.33.43 PM.png (219×483 px, 28 KB)
Screen Shot 2018-12-02 at 10.39.26 PM.png (230×473 px, 29 KB)
Screen Shot 2018-12-02 at 10.50.37 PM.png (228×475 px, 30 KB)

All Wikidata descriptions editing events should contains the following fields: action, wikidataDescriptionEdit, anon, app_install_id, session_token, client_dt. If the edit is saved successfully, we record the revision number in the revID field with the action=saved. If there is any error, we record the error message returned in the errorText field with the action=error.

Related Objects
Search...

Event Timeline

• chelsyx created this task.Dec 3 2018, 6:59 AM
• chelsyx added a parent task: T203723: As a product analyst I would like to know how people are using the Wikidata Descriptions editing features.
• chelsyx moved this task from Triage to Tracking on the Product-Analytics board.
• chelsyx mentioned this in T203723: As a product analyst I would like to know how people are using the Wikidata Descriptions editing features.Dec 3 2018, 7:08 AM
• JMinor triaged this task as Low priority.Dec 3 2018, 7:23 PM
• JMinor moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.
• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Dec 3 2018, 7:37 PM
• chelsyx updated the task description. (Show Details)Dec 3 2018, 7:53 PM
• chelsyx updated the task description. (Show Details)Dec 4 2018, 9:40 PM
• JMinor assigned this task to • chelsyx.Dec 13 2018, 8:28 PM
• chelsyx removed • chelsyx as the assignee of this task.Dec 14 2018, 9:49 PM
• JMinor moved this task from Needs Acceptance Criteria to Ready for Development on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Jan 10 2019, 7:11 PM
• NHarateh_WMF claimed this task.Jan 23 2019, 12:33 PM
• NHarateh_WMF moved this task from Ready for Development to Doing on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.
• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Jan 23 2019, 8:52 PM
• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Jan 24 2019, 10:17 AM
• chelsyx mentioned this in T214627: Data QA for Wikidata descriptions editing eventlogging on iOS app.Jan 24 2019, 7:16 PM
• chelsyx added a subtask: T214627: Data QA for Wikidata descriptions editing eventlogging on iOS app.
• NHarateh_WMF moved this task from Waiting for Build to Needs QA on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Feb 5 2019, 7:36 PM

Moving to QA so that @chelsyx can take a look

• chelsyx added a comment.Feb 6 2019, 9:50 PM

Hi @NHarateh_WMF , I just QA the eventlogging for Wikidata descriptions editing. Could you fix the following things?

  • Value for wiki should be the same as the article's wiki. Currently when I edit on an article from Chinese Wikipedia (zhwiki), the events are showing "wiki":"enwiki"
  • Currently "action":"ready" is sent twice: (1) when new users see the editing tutorial (as shown in the picture below) (2) when the "Add a description" screen is shown (as shown in the description of this task). Could you remove (1) and only send the event when the "Add a description" screen is shown?
  • When the edit is saved, there is a revision number returned, can you add that to the event when "action":"saved"?
  • When an error is emitted, can you add the error message returned as the value of key errorText (when "action":"error")?

02 Wikidata descriptions.png (1×750 px, 78 KB)

JoeWalsh subscribed.Feb 7 2019, 1:37 PM

@chelsyx can you confirm that you want the localized error message displayed to the user in errorText as implied this screenshot?

Screen Shot 2018-12-02 at 10.50.37 PM.png (228×475 px, 30 KB)

Would the unlocalized error code string returned by the server be better?

ABorbaWMF reassigned this task from • NHarateh_WMF to • chelsyx.Feb 7 2019, 6:30 PM
ABorbaWMF added subscribers: • NHarateh_WMF, ABorbaWMF.

@chelsyx can you take a look at this one and verify it all seems copacetic?

• chelsyx added a comment.Feb 7 2019, 6:34 PM

Would the unlocalized error code string returned by the server be better?

@JoeWalsh Yes! The unlocalized error code string is better!

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Feb 7 2019, 6:52 PM
• chelsyx added a comment.Feb 12 2019, 7:42 PM

Thanks for the fix! This looks great!

• chelsyx closed subtask T214627: Data QA for Wikidata descriptions editing eventlogging on iOS app as Resolved.Feb 16 2019, 6:34 AM
• JMinor closed this task as Resolved.Feb 21 2019, 9:34 PM
• chelsyx mentioned this in T214628: As a PM I'd like to know how many iOS app user are blocked from editing and registration.Feb 21 2019, 9:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL