Taking a look here it looks like protect-level-centralnotice-admin is missing. We should add it to WikimediaMessages. I'll do so shortly.
Description
Details
Related Objects
- Mentioned Here
- T209763: Right 'banner-protect' is missing i18n descriptions
Event Timeline
Change 477236 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/WikimediaMessages@master] Add new "centralnotice-admin" protection level messages
I was looking too to right-edit.* messages, but I couldn't find it is needed here.
(I am refering to a potential right-editcentralnotice-adminprotected)
Those in core are used via EditPage.php/etc.; how did this protection level get created? It's not listed at https://meta.wikimedia.org/wiki/Special:ListGroupRights so I don't think it's needed?
@Jdforrester-WMF I think this got added at:
- https://github.com/wikimedia/mediawiki-extensions-CentralNotice/commit/c164783ee2936a192666ee6d54ed9ff9fe21c697
- https://github.com/wikimedia/mediawiki-extensions-CentralNotice/commit/ac6295c3660a3643b1bb5ee02441a7da5801a2bd
- https://github.com/wikimedia/mediawiki-extensions-CentralNotice/commit/a5b313996b23484e29b9a6cd2a1cdbf091803214
However the centralnotice-admin permission is not part of CentralNotice itself (it was an ad hoc permission created on Meta-Wiki to allow non-admins to access CN) so I'm not sure why CN is using a custom permission that only exists at wmf-config (cfr. extension.json and wmf-config (permalink)).
Hmm, if it's just done through hooks then we don't need another message, I think. Let's merge your patch.
So the metawiki group is called 'centralnoticeadmin' with the permission 'centralnotice-admin' inside it. And pages are getting protected to the 'centralnotice-admin' level which only 'centralnoticeadmin' people have access to. It gets confusing at times :)
Change 477236 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Add new "centralnotice-admin" protection level messages
Hi, quick question... (Just revisiting this while looking at T209763.) Since CentralNotice does actually use the centralnotice-admin right for page protections, as hardcoded here, shouldn't restriction-level-centralnotice-admin and protect-level-centralnotice-admin messages be included in the extension, rather than in WikimediaMessages? Not a big issue, in any case, and thanks again for the help on this! :)
Change 484278 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Include i18n descriptions for CN-admin page protection
Change 484283 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/WikimediaMessages@master] Remove messages for centralnotice-admin permissios
Change 484283 abandoned by MarcoAurelio:
Remove messages for centralnotice-admin permissions
Reason:
Let's just create a revert of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMessages/ /477236/ instead.
Sorry, what a mess between WikimediaMessages and CentralNotice. To sumarise:
- https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/484278/ adds to CentralNotice the keys we added to WikimediaMessages.
- https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMessages/+/484394/ reverts from WikimediaMessages the addition we did there.
I think this is now really ready. @Raymond Shall we delete from translatewiki the keys we added to WikimediaMessages and that are now being added to CentralNotice to avoid duplicates? Thanks.
Change 484278 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Include i18n descriptions for CN-admin page protection