Those in core are used via EditPage.php/etc.; how did this protection level get created? It's not listed at https://meta.wikimedia.org/wiki/Special:ListGroupRights so I don't think it's needed?
@Jdforrester-WMF I think this got added at:
However the centralnotice-admin permission is not part of CentralNotice itself (it was an ad hoc permission created on Meta-Wiki to allow non-admins to access CN) so I'm not sure why CN is using a custom permission that only exists at wmf-config (cfr. extension.json and wmf-config (permalink)).
So the metawiki group is called 'centralnoticeadmin' with the permission 'centralnotice-admin' inside it. And pages are getting protected to the 'centralnotice-admin' level which only 'centralnoticeadmin' people have access to. It gets confusing at times :)
Hi, quick question... (Just revisiting this while looking at T209763.) Since CentralNotice does actually use the centralnotice-admin right for page protections, as hardcoded here, shouldn't restriction-level-centralnotice-admin and protect-level-centralnotice-admin messages be included in the extension, rather than in WikimediaMessages? Not a big issue, in any case, and thanks again for the help on this! :)
Change 484283 abandoned by MarcoAurelio:
Remove messages for centralnotice-admin permissions
Let's just create a revert of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMessages/ /477236/ instead.
Sorry, what a mess between WikimediaMessages and CentralNotice. To sumarise:
- https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/484278/ adds to CentralNotice the keys we added to WikimediaMessages.
- https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMessages/+/484394/ reverts from WikimediaMessages the addition we did there.
I think this is now really ready. @Raymond Shall we delete from translatewiki the keys we added to WikimediaMessages and that are now being added to CentralNotice to avoid duplicates? Thanks.