Page MenuHomePhabricator

Deprecate Diamond collectors in Tool Labs / Tool Forge
Closed, DuplicatePublic

Description

Diamond is being deprecated, I checked for remaining collectors used in ToolLabs/Toolforge:

  • toollabs::mailrelay: diamond::collector::extendedexim { 'extended_exim_collector': }

In production metrics were ported to Prometheus in T179565, that can probably be reused/adapted.

  • class toollabs: diamond::collector::localcrontab { 'localcrontabcollector': }

Needs some investigation for replacement.

  • toollabs::services: diamond::collector { 'SGE' } (custom exporter from puppet.git)

Will need to be ported to a custom exporter (if still needed).

  • toollabs::redis: diamond::collector { 'Redis' }

In production metrics were ported to Prometheus in T148637, that can probably be reused/adapted.

  • profile::toolforge::mailrelay: diamond::collector::extendedexim { 'extended_exim_collector': }

In production metrics were ported to Prometheus in T179565, that can probably be reused/adapted.

  • profile::toolforge::services::basic: diamond::collector { 'SGE':

Will need to be ported to a custom exporter (if still needed).

  • profile::toolforge::grid::base: diamond::collector::localcrontab { 'localcrontabcollector': }

Needs some investigation for replacement.

Event Timeline

MoritzMuehlenhoff triaged this task as Medium priority.

Since diamond is being dropped from Debian, let's review this soon.

JFTR, there's no immediate hurry, it was removed from Debian unstable, i.e. Diamond will not be part of the next Debian release in 1.5 years, but this doesn't affect existing releases (removals from stable releases are only done in exceptional cases)

I am going to merge this into T210993: Deprecate Diamond collectors in Cloud VPS and copy the data from the task description over there. Having two tasks which mix Cloud VPS and Toolforge mostly based on our horrible Puppet organization is not particularly helpful for cleanup.