Page MenuHomePhabricator

Deprecate Diamond collectors in Cloud VPS
Open, NormalPublic

Description

Diamond is being deprecated, I checked for remaining collectors used in Cloud VPS:

  • role::beta::availability_collector: diamond::collector { 'VarnishStatus' }

This is a custom collector deployed via Puppet (modules/diamond/files/collector/varnishstatus.py), it should be pretty straightforward to convert (per watroles it's currently in use on deployment-cache-upload04, so seems still in use).

  • role::labs::instance: diamond::collector { 'SSHSessions' }

This is a custom collector deployed via Puppet (modules/diamond/files/collector/sshsessions.py), it should be pretty straightforward to convert. I think this would even be a useful metric to be collected in general (i.e. also for production), integration could be done via the prometheus-node-exporter textfile collector (see prometheus::node_intel_microcode).

  • role::labs::instance: diamond::collector diamond::collector::minimalpuppetagent { 'minimal-puppet-agent' }

This is a custom collector deployed via Puppet (modules/diamond/collector/minimalpuppetagent.py). it should be pretty straightforward to convert. I think this would even be a useful metric to be collected in general (i.e. also for production), integration could be done via the prometheus-node-exporter textfile collector (see prometheus::node_intel_microcode).

  • class puppetmaster::gitsync (used by role::puppetmaster::standalone): diamond::collector { 'CherryPickCounter' }

This is a custom collector deployed via Puppet (modules/puppetmaster/files/cherry-pick-counter-collector.py). it should be pretty straightforward to convert.

  • define labstore::nfs_mount: diamond::collector { 'Nfsiostat' }

This is a custom collector deployed via Puppet (modules/diamond/files/collector/nfsiostat.py), I doubt there's an existing Prometheus exporter for this use case, so probably the existing one needs to be converted.

Event Timeline

GTirloni removed a subscriber: GTirloni.Mar 23 2019, 8:46 PM
fgiunchedi moved this task from Backlog to Radar on the User-fgiunchedi board.May 13 2019, 8:58 AM

Change 522405 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove CherryPickCounter Diamond collector

https://gerrit.wikimedia.org/r/522405

Change 522405 merged by Muehlenhoff:
[operations/puppet@production] Remove CherryPickCounter Diamond collector

https://gerrit.wikimedia.org/r/522405