Page MenuHomePhabricator

CLI installer does not set $wgLanguageCode when passing "--lang"
Closed, ResolvedPublic

Description

When executing something like

php maintenance/install.php ... --lang de ...

the resulting LocalSettings.php will contain $wgLanguageCode = "en"; The value of the argument --lang is not properly passed to LocalSettingsGenerator.

Details

Event Timeline

Osnard created this task.Dec 3 2018, 10:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2018, 10:47 AM

Change 477239 had a related patch set uploaded (by Robert Vogel; owner: Robert Vogel):
[mediawiki/core@master] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477239

It would be cool if this change could be cherry-picked to REL1_31.

Aklapper renamed this task from CLI installer forgets about "--lang" to CLI installer does not set $wgLanguageCode when passing "--lang".Dec 3 2018, 1:03 PM
Legoktm added a subscriber: Legoktm.

It would be cool if this change could be cherry-picked to REL1_31.

Can do. In the future, tagging the task with MW-1.31-release will also indicate that.

Change 477239 merged by jenkins-bot:
[mediawiki/core@master] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477239

Change 477460 had a related patch set uploaded (by Legoktm; owner: Robert Vogel):
[mediawiki/core@REL1_32] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477460

Change 477461 had a related patch set uploaded (by Legoktm; owner: Robert Vogel):
[mediawiki/core@REL1_31] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477461

Change 477461 merged by jenkins-bot:
[mediawiki/core@REL1_31] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477461

Change 477460 merged by jenkins-bot:
[mediawiki/core@REL1_32] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477460

Legoktm closed this task as Resolved.Dec 4 2018, 7:40 AM
Legoktm assigned this task to Osnard.