Page MenuHomePhabricator
Create Task
Maniphest T210998

CLI installer does not set $wgLanguageCode when passing "--lang"
Closed, ResolvedPublic
Actions

Description

When executing something like

php maintenance/install.php ... --lang de ...

the resulting LocalSettings.php will contain $wgLanguageCode = "en"; The value of the argument --lang is not properly passed to LocalSettingsGenerator.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Save value from CLI installers `--lang` argumentmediawiki/coreREL1_32+3 -0
Save value from CLI installers `--lang` argumentmediawiki/coreREL1_31+3 -1
Save value from CLI installers `--lang` argumentmediawiki/coremaster+1 -0
Customize query in gerrit

Event Timeline

Osnard created this task.Dec 3 2018, 10:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2018, 10:47 AM
gerritbot subscribed.Dec 3 2018, 10:49 AM

Change 477239 had a related patch set uploaded (by Robert Vogel; owner: Robert Vogel):
[mediawiki/core@master] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477239

gerritbot added a project: Patch-For-Review.Dec 3 2018, 10:49 AM
Osnard added a comment.Dec 3 2018, 10:50 AM

It would be cool if this change could be cherry-picked to REL1_31.

Aklapper renamed this task from CLI installer forgets about "--lang" to CLI installer does not set $wgLanguageCode when passing "--lang".Dec 3 2018, 1:03 PM
Legoktm added projects: MW-1.31-release, MW-1.32-release.Dec 4 2018, 6:15 AM
Legoktm subscribed.
In T210998#4793618, @Osnard wrote:

It would be cool if this change could be cherry-picked to REL1_31.

Can do. In the future, tagging the task with MW-1.31-release will also indicate that.

gerritbot added a comment.Dec 4 2018, 6:52 AM

Change 477239 merged by jenkins-bot:
[mediawiki/core@master] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477239

gerritbot added a comment.Dec 4 2018, 6:57 AM

Change 477460 had a related patch set uploaded (by Legoktm; owner: Robert Vogel):
[mediawiki/core@REL1_32] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477460

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 4 2018, 7:00 AM
gerritbot added a comment.Dec 4 2018, 7:03 AM

Change 477461 had a related patch set uploaded (by Legoktm; owner: Robert Vogel):
[mediawiki/core@REL1_31] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477461

gerritbot added a comment.Dec 4 2018, 7:17 AM

Change 477461 merged by jenkins-bot:
[mediawiki/core@REL1_31] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477461

gerritbot added a comment.Dec 4 2018, 7:26 AM

Change 477460 merged by jenkins-bot:
[mediawiki/core@REL1_32] Save value from CLI installers --lang argument

https://gerrit.wikimedia.org/r/477460

Legoktm closed this task as Resolved.Dec 4 2018, 7:40 AM
Legoktm assigned this task to Osnard.
ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.32-notes.Dec 4 2018, 8:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits