Page MenuHomePhabricator

Remove PDF banner on Special:ElectronPdf
Closed, ResolvedPublic3 Estimated Story Points

Description

We need to remove the banner appearing on the PDF download page (https://en.wikipedia.org/w/index.php?title=Special:ElectronPdf&page=Main+Page&action=show-download-screen) after

Screen Shot 2018-12-03 at 12.08.42 PM.png (403×740 px, 49 KB)

Acceptance criteria

  • Make sure the proton renderer has been live for at least two weeks
  • Remove banner

QA

  1. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
  2. Tap "Download as PDF"
  3. Ensure the yellow banner is gone!
NOTE: we will only remove this banner, the books banner will stay up until we can get the books functionality back.

Event Timeline

ovasileva created this task.
ovasileva set the point value for this task to 2.Dec 5 2018, 5:34 PM
Jdlrobson changed the task status from Open to Stalled.Apr 3 2019, 3:41 AM
Jdlrobson added a subscriber: Jdlrobson.

This is stalled as I understand it.

TheDJ changed the task status from Stalled to Open.Jun 4 2019, 12:24 PM
TheDJ moved this task from Triaged but Future to Upcoming on the Readers-Web-Backlog board.
ovasileva changed the point value for this task from 2 to 3.Jun 4 2019, 4:10 PM
Aklapper renamed this task from Remove PDF banner to Remove PDF banner on Special:ElectronPdf.Jun 5 2019, 10:24 AM

Change 517714 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/ElectronPdfService@master] Revert "Add warning message to Special:ElectronPdf"

https://gerrit.wikimedia.org/r/517714

Change 517714 merged by jenkins-bot:
[mediawiki/extensions/ElectronPdfService@master] Revert "Add warning message to Special:ElectronPdf"

https://gerrit.wikimedia.org/r/517714

Edtadros added a subscriber: Niedzielski.

@Niedzielski I can't seem to find the download as pdf link. I tried it Logged In/Out, AMC ON/OFF, Beta ON/OFF, Mobile and Desktop.

@Edtadros, sorry, you need to be on the desktop site.

Screenshot from 2019-06-19 18-16-52.png (1×1 px, 387 KB)

@Niedzielski, of course I missed that....of course...

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):

QA

  1. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
  2. Tap "Download as PDF"
  3. Ensure the yellow banner is gone!

✅ AC1:

T211002.gif (946×1 px, 380 KB)