In AbuseFilter, we use the word "private" inside user rights, methods and variables names, comments etc. to indicate two separate things:
- Private filters, i.e. filters that you can only see with the abusefilter-view-private right (abusefilter-view is not enough)
- Private details, i.e. private user info stored in the AbuseLog (simplyfing, their IP address)
It's pretty obvious that these two things are really different, but several parts of the code are confusing. For instance:
- The 'abusefilter-private-log' right (which allows people to view the private details access log)
- The 'abusefilter-private' right (allows people to access private details)
... And other examples can be found looking at the code.
Probably we should change "private" to "privatedetails" for the use case #2.