Page MenuHomePhabricator

action=parsermigration-edit not supported by local edit summary gadget on pl.wikipedia
Closed, InvalidPublic

Description

Error

When user is coming from URL that uses action=parsermigration-edit then buttons for description of edit are not visible.

When I was fixing defects from this special page
https://pl.wikipedia.org/wiki/Special:LintErrors/multiple-unclosed-formatting-tags?namespace=0
I spotted that I don't have buttons for adding edit description. I have a field for adding edit description - but no buttons.

Checked on private mode and on my account pl:USER:PMG


URL used in screenshots:
https://pl.wikipedia.org/w/index.php?title=Number_Ones_(album_Janet_Jackson)&action=edit&lintid=4033797

https://pl.wikipedia.org/w/index.php?title=Number_Ones_(album_Janet_Jackson)&action=parsermigration-edit&lintid=4033797

Browsers: checked on Chrome 70 and Firefox 63 (Windows 10)

Impact

Small, but annoing.

Notes

Event Timeline

PMG created this task.Dec 3 2018, 5:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2018, 5:08 PM

Hi @PMG, thanks for taking the time to report this and welcome to Wikimedia Phabricator!

(Removing the Wikimedia-production-error tag as there is no crash reported in this task, and hence no stacktrace in the error logs.)

Looking at https://pl.wikipedia.org/wiki/MediaWiki:Gadgets-definition#editing , that area of green boxes seems to come from a local gadget located at https://pl.wikipedia.org/wiki/MediaWiki:Gadget-edit-summaries.js. In my understanding, that code defines for which actions the buttons are shown in
if (mw.config.get('wgAction') == 'edit' || mw.config.get('wgAction') == 'submit')

Have you tried also covering the action= parameter 'parsermigration-edit' in that line, in addition to 'edit' and 'submit'?

Wargo closed this task as Resolved.Dec 3 2018, 8:00 PM
Wargo triaged this task as Low priority.
Wargo claimed this task.
Wargo added a subscriber: Wargo.

Done.

This was gadget issue, report locally.

Aklapper renamed this task from action=parsermigration-edit is not triggering buttons for edit description to action=parsermigration-edit not supported by local edit summary gadget on pl.wikipedia.Dec 4 2018, 9:23 AM
Aklapper changed the task status from Resolved to Invalid.