Description

Hi, since we migrated to actor (under mw 1.31) we cannot search by users in Special:ListFiles.

Looking at the code, it's indeed incompatible with actor, see https://github.com/wikimedia/mediawiki/blob/master/includes/specials/pagers/ImageListPager.php#L137 that column is empty for me (the column is there but the value is empty and img_user is 0)

Details

Subject	Repo	Branch	Lines +/-
ImageListPager: Actor migration for buildQueryConds()	mediawiki/core	REL1_32	+8 -1
ImageListPager: Actor migration for buildQueryConds()	mediawiki/core	REL1_31	+8 -1
ImageListPager: Actor migration for buildQueryConds()	mediawiki/core	master	+8 -1

Customize query in gerrit

Event Timeline

Paladox created this task.Dec 3 2018, 10:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2018, 10:23 PM

(this special page should support actor as it's a core special page hence high priority)

Krinkle added projects: MW-1.33-release, Platform Engineering, Regression.Dec 4 2018, 5:10 AM

Speculatively adding a few tags as it wasn't on any triaged workboard. Apologies if tagged incorrectly, please correct, forward or delegate as appropriate.

Anomie added a project: Platform Team Workboards (Waiting for Review).Dec 4 2018, 4:12 PM

Change 477578 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ImageListPager: Actor migration for buildQueryConds()

https://gerrit.wikimedia.org/r/477578

gerritbot added a project: Patch-For-Review.Dec 4 2018, 4:12 PM

Change 477578 merged by jenkins-bot:
[mediawiki/core@master] ImageListPager: Actor migration for buildQueryConds()

https://gerrit.wikimedia.org/r/477578

Change 477907 had a related patch set uploaded (by Paladox; owner: Anomie):
[mediawiki/core@REL1_32] ImageListPager: Actor migration for buildQueryConds()

https://gerrit.wikimedia.org/r/477907

Change 477908 had a related patch set uploaded (by Paladox; owner: Anomie):
[mediawiki/core@REL1_31] ImageListPager: Actor migration for buildQueryConds()

https://gerrit.wikimedia.org/r/477908

Change 477908 merged by jenkins-bot:
[mediawiki/core@REL1_31] ImageListPager: Actor migration for buildQueryConds()

https://gerrit.wikimedia.org/r/477908

Anomie closed this task as Resolved.Dec 5 2018, 9:58 PM

Anomie claimed this task.

ReleaseTaggerBot added projects: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.31-release-notes.Dec 5 2018, 10:01 PM

Change 477907 merged by jenkins-bot:
[mediawiki/core@REL1_32] ImageListPager: Actor migration for buildQueryConds()

https://gerrit.wikimedia.org/r/477907

ReleaseTaggerBot added a project: MW-1.32-notes.Dec 5 2018, 11:00 PM

CCicalese_WMF moved this task from Waiting for Review to Done with CPT on the Platform Team Workboards board.Dec 13 2018, 8:09 PM

CCicalese_WMF edited projects, added Platform Team Workboards (Done with CPT); removed Platform Team Workboards (Waiting for Review).

CCicalese_WMF moved this task from Inbox to Needs Cleaning - Security, stability, performance, and scalability (TEC1) on the Platform Engineering board.Dec 13 2018, 8:11 PM