Page MenuHomePhabricator

check $wgUseExternalEditor, $wgExternalDiffEngine before showing Preference
Closed, ResolvedPublic


externaleditor, externaldiff checks

In this patch we add checks for $wgUseExternalEditor, $wgExternalDiffEngine, before presenting the corresponding options to the user.

Version: 1.16.x
Severity: minor




Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:37 PM
bzimport set Reference to bz19112.
bzimport added a subscriber: Unknown Object (MLST).

(An administrator should probably reset any users' bad choces with
maintenance/userOptions.php before locking the power to change them
away from them.)

Looks good. Can't commit from here, though. If no one else commits, I'll grab this tonight after work.