Page MenuHomePhabricator

Usual git mechanism for aborting commit does not work on the private puppet repo
Closed, ResolvedPublic

Description

The comment in the git commit template says "and an empty message aborts the commit". Except that in the private repo, our hook doesn't check for this, and helpfully adds in $SUDO_USER, and so by the time git sees it again the commit message is decidedly non-empty.

This isn't too big a deal, but has bit myself and @akosiaris in the past few weeks.

Event Timeline

jijiki triaged this task as Medium priority.Dec 4 2018, 9:46 PM
jijiki updated the task description. (Show Details)
jbond subscribed.

Can you confirm is this is still an issue i just tried to recreate and it looks to work as expected now

jbond claimed this task.

closing, but please re-open if its still an issue