Page MenuHomePhabricator
Create Task
Maniphest T211125

Move service-runner to new logging infrastructure
Closed, ResolvedPublic
Actions

Description

Similarly to T211124: Move mediawiki to new logging infrastructure this task is about tracking the necessary changes to service-runner to use the new logging infrastructure.

The general transports/protocols involved are syslog + JSON, specifically a @cee: token/cookie is required to prefix the json payload to properly recognize said message as json/structured logging (see also https://www.rsyslog.com/doc/v8-stable/configuration/modules/mmjsonparse.html). For transport the preferred way is through unix socket /dev/log (managed by journald, then messages are read by rsyslogd) though a compatibility udp endpoint can also be provided if needed.

Additional information/context: https://wikitech.wikimedia.org/wiki/Logstash/SRE_onboard

Details

ProjectBranchLines +/-Subject
mediawiki/services/parsoid/deploymaster+6 -5Switch logging to rsyslog
mediawiki/services/parsoidmaster+953 -190Bump to service-runner@2.6.19
mediawiki/services/change-propagation/jobqueue-deploymaster+6 -5Switch logging to rsyslog.
mediawiki/services/change-propagation/deploymaster+6 -5Use rsyslog for logging.
mediawiki/services/restbase/deploymaster+0 -9Enable rsyslog logging for production.
mediawiki/services/restbase/deploymaster+10 -0Enable rsyslog logging in deployment-prep.
operations/puppetproduction+13 -7Expose rsyslog_udp_port to services configs.
operations/puppetproduction+5 -0Add rsyslog kafka to service nodes.
operations/puppetproduction+34 -6Create node-specific logstash filters for syslog.
operations/puppetproduction+15 -9Map syslog{severity,facility}-text to {severity,facility}_label
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
mobrovac edited projects, added Services (next), Platform Team Legacy (Next); removed Services.Dec 4 2018, 4:57 PM
fgiunchedi updated the task description. (Show Details)Dec 5 2018, 11:03 AM
Pchelolo added subscribers: mobrovac, Pchelolo.Dec 5 2018, 8:35 PM

So, currently we only support sending to syslog via UDP using the node-bunyan-syslog-upd package created by @mobrovac It's pure-js implementation since we want to avoid native bindings.

Searching for existing libraries for bynuan-syslog adapters doesn't reveal a lot and it's a mess. Most of the packages do not look supported or well-used. The only implementation that claims to support Unix dgram sockets seems abandoned, plus it uses unix-dgram package under the hood that is introducing a native binding. There are some implementations for just syslog clients, without bunyan support, but even though we just need a domain socket (supported out of the box in node) they all rely on unix-dgram package.

To sum up, I would not be comfortable relying on any of the existing implementations. How much more preferable Unix sockets would be over UDP as a transport? I will try to implement a proof of concept implementation that does not rely on a bulk of the native code, let's see how that goes.

Pchelolo added a comment.Dec 5 2018, 10:06 PM

Oh.... Apparently, apple have broken syslog in newer OSX versions, so I'm most certainly not the best persong to tackle this task. Supposedly, if we support receiving logs over UDP everything should work out of the box. If you're not too opposed to UDP transport, we could test it in beta almost immediately.

fgiunchedi added a comment.Dec 7 2018, 9:09 AM
In T211125#4801464, @Pchelolo wrote:

So, currently we only support sending to syslog via UDP using the node-bunyan-syslog-upd package created by @mobrovac It's pure-js implementation since we want to avoid native bindings.

Searching for existing libraries for bynuan-syslog adapters doesn't reveal a lot and it's a mess. Most of the packages do not look supported or well-used. The only implementation that claims to support Unix dgram sockets seems abandoned, plus it uses unix-dgram package under the hood that is introducing a native binding. There are some implementations for just syslog clients, without bunyan support, but even though we just need a domain socket (supported out of the box in node) they all rely on unix-dgram package.

To sum up, I would not be comfortable relying on any of the existing implementations. How much more preferable Unix sockets would be over UDP as a transport? I will try to implement a proof of concept implementation that does not rely on a bulk of the native code, let's see how that goes.

One significant difference between the two is that logs logged through the unix socket have additional metadata associated provided by the kernel (trusted properties as rsyslog calls those). One other difference is blocking behavior of AF_INET vs AF_UNIX sockets e.g. when there are no readers. Eventually I think we'd want all log producers to unix sockets, though local UDP will do as a compatibility shim until we do so.

I'd say let's go with UDP in beta at least to kick the tires! Which beta hosts (or better: puppet roles/profiles) should have the udp endpoint enabled?

Pchelolo added a comment.Dec 7 2018, 2:57 PM

There's not that much logging happening in beta services, I would guess we should start big, so deployment-restbase0[1,2]?

Will the logs go to logstash-beta.wmflabs.org or will just be local to the node in syslog for now?

fgiunchedi added a comment.Dec 11 2018, 12:19 PM
In T211125#4806051, @Pchelolo wrote:

There's not that much logging happening in beta services, I would guess we should start big, so deployment-restbase0[1,2]?

Sounds good to me! You should be able to send the cee-prefixed json logs already on those hosts in beta, udp on localhost:10514 (i.e. same port as logstash syslog)

Will the logs go to logstash-beta.wmflabs.org or will just be local to the node in syslog for now?

The former, logs will be ingested into logstash

mobrovac edited projects, added Platform Team Legacy (Later); removed Platform Team Legacy (Next).Dec 20 2018, 12:16 PM
• Phabricator_maintenance moved this task from Backlog to Acknowledged on the SRE board.Jan 26 2019, 10:49 PM
Pchelolo assigned this task to • holger.knust.Feb 4 2019, 12:01 AM

We need to locally test whether the bynuan-syslog-udp actually works and modify it to add the @cee annotation. Then we can proceed with testing in beta cluster.

gerritbot added a comment.Mar 15 2019, 6:38 PM

Change 496813 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/puppet@production] Add rsyslog kafka to service nodes.

https://gerrit.wikimedia.org/r/496813

gerritbot added a project: Patch-For-Review.Mar 15 2019, 6:38 PM
Pchelolo added a comment.Mar 18 2019, 3:07 PM

After enabling logging over syslog for RESTBase in deployment-prep, we have identified a number of disparities between node services and, for example, mediawiki.

In the old pipeline, we've used gelf protocol to deliver the logs directly from services to logstash. So, there were 2 mappings:

  • gelf-stream library to map 'bunyan' log format into gelf. Examples of mappins are renaming msg to short_message, name to facility etc.
  • A special gelf formatter for logstash that additionally modified the message. For example renaming 'facility' into 'type' etc.

After a switch to syslog both of the mappings have been broken. We need to figure out what to do here. Given that most of these disparities are withing the JSON payload of the log entry, there's no real protocol to follow.

Our options are:

  1. Try to modify bunyan-syslog-udp to conform to current rsyslog mappings as much as possible. This will not be possible completely since some property names in bunyan are not configurable. For example, msg. So we would need to create logstash mappings to remove the msg anyway. Additionally, it will make the bunyan-syslog-udp library quite opinionated and tied to WMF production environment.
  2. Create custom syslog mapper for node services in addition to a special formatter in logstash. In a first glance the configuration will be more complex, but I think in the end it is better.

@fgiunchedi what do you think?

gerritbot added a comment.Mar 18 2019, 3:34 PM

Change 497321 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/puppet@production] Map syslogseverity-text to severity_label.

https://gerrit.wikimedia.org/r/497321

gerritbot added a comment.Mar 22 2019, 2:33 PM

Change 497321 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/puppet@production] Map syslog{severity,facility}-text to {severity,facility}_label

https://gerrit.wikimedia.org/r/497321

gerritbot added a comment.Mar 22 2019, 4:17 PM

Change 498417 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/puppet@production] Create node-specific logstash filters for syslog.

https://gerrit.wikimedia.org/r/498417

gerritbot added a comment.Mar 25 2019, 11:31 AM

Change 497321 abandoned by Ppchelko:
Map syslog{severity,facility}-text to {severity,facility}_label

Reason:
godog: Pchelolo: ah, yeah that's correct the _label fields are artifacts of syslog-input plugin
godog: I'd rather drop having both number and text representation while we're at it and go with severity/facility in text form

https://gerrit.wikimedia.org/r/497321

gerritbot added a comment.Mar 25 2019, 2:19 PM

Change 498872 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/puppet@production] Enable rsyslog logging for node services.

https://gerrit.wikimedia.org/r/498872

gerritbot added a comment.Mar 25 2019, 3:03 PM

Change 498899 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/services/restbase/deploy@master] Enable rsyslog logging in deployment-prep.

https://gerrit.wikimedia.org/r/498899

gerritbot added a comment.Mar 27 2019, 1:54 PM

Change 498417 merged by Filippo Giunchedi:
[operations/puppet@production] Create node-specific logstash filters for syslog.

https://gerrit.wikimedia.org/r/498417

gerritbot added a comment.Apr 1 2019, 3:21 PM

Change 496813 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Ppchelko):
[operations/puppet@production] Add rsyslog kafka to service nodes.

https://gerrit.wikimedia.org/r/496813

gerritbot added a comment.Apr 1 2019, 3:23 PM

Change 496813 merged by Giuseppe Lavagetto:
[operations/puppet@production] Add rsyslog kafka to service nodes.

https://gerrit.wikimedia.org/r/496813

gerritbot added a comment.Apr 2 2019, 6:48 AM

Change 498872 merged by Giuseppe Lavagetto:
[operations/puppet@production] Expose rsyslog_udp_port to services configs.

https://gerrit.wikimedia.org/r/498872

gerritbot added a comment.Apr 2 2019, 2:37 PM

Change 498899 merged by Ppchelko:
[mediawiki/services/restbase/deploy@master] Enable rsyslog logging in deployment-prep.

https://gerrit.wikimedia.org/r/498899

gerritbot added a comment.Apr 2 2019, 3:38 PM

Change 500767 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/services/restbase/deploy@master] Enable rsyslog logging for production.

https://gerrit.wikimedia.org/r/500767

gerritbot added a comment.Apr 2 2019, 5:53 PM

Change 500767 merged by Ppchelko:
[mediawiki/services/restbase/deploy@master] Enable rsyslog logging for production.

https://gerrit.wikimedia.org/r/500767

Stashbot added a comment.Apr 2 2019, 5:56 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-02T17:56:04Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@2cb53a7] (dev-cluster): Kafka logging pipeline, dev cluster only T211125

Stashbot added a comment.Apr 2 2019, 5:59 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-02T17:59:29Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@2cb53a7] (dev-cluster): Kafka logging pipeline, dev cluster only T211125 (duration: 03m 25s)

Stashbot added a comment.Apr 2 2019, 6:06 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-02T18:06:23Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@2cb53a7]: Kafka logging pipeline, canary on restbase2010 T211125

Stashbot added a comment.Apr 2 2019, 6:09 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-02T18:08:56Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@2cb53a7]: Kafka logging pipeline, canary on restbase2010 T211125 (duration: 02m 33s)

Stashbot added a comment.Apr 2 2019, 6:20 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-02T18:20:09Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@2cb53a7]: Kafka logging pipeline, full deploy T211125

Stashbot added a comment.Apr 2 2019, 6:20 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-02T18:20:13Z] <ppchelko@deploy1001> deploy aborted: Kafka logging pipeline, full deploy T211125 (duration: 00m 03s)

Stashbot added a comment.Apr 2 2019, 6:20 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-02T18:20:22Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@2cb53a7]: Kafka logging pipeline, full deploy T211125

Stashbot added a comment.Apr 2 2019, 6:41 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-02T18:41:10Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@2cb53a7]: Kafka logging pipeline, full deploy T211125 (duration: 20m 49s)

Pchelolo added a comment.Apr 2 2019, 7:09 PM

I have deployed a new pipeline for RESTBase in production and it all looks great. Next step - convert other services. I will try it out on change-prop and create subtasks for individual services.

gerritbot added a comment.Apr 2 2019, 7:15 PM

Change 500813 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/services/change-propagation/deploy@master] Use rsyslog for logging.

https://gerrit.wikimedia.org/r/500813

Pchelolo claimed this task.Apr 2 2019, 7:17 PM
Pchelolo edited projects, added Services (done), Platform Team Workboards (Done with CPT); removed Patch-For-Review, Platform Team Legacy (Later), Services (next).
Pchelolo added a subscriber: • holger.knust.
gerritbot added a comment.Apr 2 2019, 7:41 PM

Change 500818 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/services/change-propagation/jobqueue-deploy@master] Switch logging to rsyslog.

https://gerrit.wikimedia.org/r/500818

gerritbot added a project: Patch-For-Review.Apr 2 2019, 7:41 PM
Pchelolo mentioned this in rMSCD661225d8ba63: Use rsyslog for logging..Apr 2 2019, 8:29 PM
gerritbot added a comment.Apr 4 2019, 2:41 PM

Change 500813 merged by Ppchelko:
[mediawiki/services/change-propagation/deploy@master] Use rsyslog for logging.

https://gerrit.wikimedia.org/r/500813

Stashbot added a comment.Apr 4 2019, 5:45 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-04T17:45:47Z] <ppchelko@deploy1001> Started deploy [changeprop/deploy@f69dc9c]: Switch to new logging infrastructure T211125

Stashbot added a comment.Apr 4 2019, 5:47 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-04T17:47:31Z] <ppchelko@deploy1001> Finished deploy [changeprop/deploy@f69dc9c]: Switch to new logging infrastructure T211125 (duration: 01m 44s)

gerritbot added a comment.Apr 4 2019, 5:49 PM

Change 500818 merged by Ppchelko:
[mediawiki/services/change-propagation/jobqueue-deploy@master] Switch logging to rsyslog.

https://gerrit.wikimedia.org/r/500818

Stashbot added a comment.Apr 4 2019, 5:55 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-04T17:55:21Z] <ppchelko@deploy1001> Started deploy [cpjobqueue/deploy@922cbc0]: Switch to new logging infrastructure T211125

Stashbot added a comment.Apr 4 2019, 5:59 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-04T17:59:24Z] <ppchelko@deploy1001> Finished deploy [cpjobqueue/deploy@922cbc0]: Switch to new logging infrastructure T211125 (duration: 04m 03s)

Pchelolo added a comment.Apr 4 2019, 5:59 PM

ChangeProp and JobQueue ChangeProp has been moved to the new logging infra as well.

fgiunchedi awarded a token.Apr 5 2019, 9:33 AM
mobrovac changed the status of subtask T219923: Move graphoid logging to new logging pipeline from Open to Stalled.Apr 8 2019, 6:55 PM
bmansurov closed subtask T219926: Move recommendation-api logging to new logging pipeline as Resolved.Apr 12 2019, 4:23 PM
MSantos added a subtask: T222377: Move kartotherian/tilerator logging to new logging pipeline.May 2 2019, 4:28 PM
gerritbot added a comment.May 22 2019, 10:41 PM

Change 512064 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Bump to service-runner@2.6.18

https://gerrit.wikimedia.org/r/512064

gerritbot added a comment.May 24 2019, 4:29 PM

Change 512064 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Bump to service-runner@2.6.19

https://gerrit.wikimedia.org/r/512064

gerritbot added a comment.May 24 2019, 5:22 PM

Change 512403 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid/deploy@master] Switch logging to rsyslog

https://gerrit.wikimedia.org/r/512403

gerritbot added a comment.May 28 2019, 3:43 PM

Change 512403 merged by jenkins-bot:
[mediawiki/services/parsoid/deploy@master] Switch logging to rsyslog

https://gerrit.wikimedia.org/r/512403

Stashbot mentioned this in T219927: Move parsoid logging to new logging pipeline.May 29 2019, 8:35 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-29T20:35:53Z] <arlolra> Updated Parsoid to 8546c79 (T219927, T211125)

Arlolra closed subtask T219927: Move parsoid logging to new logging pipeline as Resolved.May 29 2019, 8:40 PM
herron added a parent task: T225122: Migrate services using deprecated Gelf logstash input to Kafka enabled logging pipeline.Jun 5 2019, 5:22 PM
herron added a parent task: T225125: Migrate Elasticsearch from deprecated Gelf logstash input to rsyslog Kafka logging pipeline.Jun 5 2019, 5:56 PM
fgiunchedi edited parent tasks, added: T227080: Deprecate all non-Kafka logstash inputs; removed: T205851: Migrate >=90% of existing Logstash traffic to the logging pipeline.Jul 2 2019, 12:54 PM
WDoranWMF moved this task from Done with CPT to Team 2 on the Platform Team Workboards board.Jul 5 2019, 7:20 PM
WDoranWMF edited projects, added Platform Team Workboards (Team 2); removed Platform Team Workboards (Done with CPT).
WDoranWMF moved this task from Backlog to Product Acceptance on the Platform Team Workboards (Team 2) board.
WDoranWMF edited projects, added Platform Team Legacy (Watching / External); removed Platform Team Workboards (Team 2), Services (done).Jul 18 2019, 8:13 PM
fgiunchedi added a project: observability.Aug 19 2019, 2:30 PM
elukey changed the status of subtask T219928: Move AQS logging to new logging pipeline from Open to Stalled.Oct 29 2019, 7:48 AM
Ottomata closed subtask T219922: Move eventstreams logging to new logging pipeline as Declined.Nov 20 2019, 7:45 PM
Pchelolo closed subtask T219923: Move graphoid logging to new logging pipeline as Declined.Nov 22 2019, 5:52 PM
• Mholloway added a subscriber: • Mholloway.Dec 17 2019, 4:25 PM
elukey changed the status of subtask T219928: Move AQS logging to new logging pipeline from Stalled to Open.Jan 15 2020, 8:42 AM
elukey closed subtask T219928: Move AQS logging to new logging pipeline as Resolved.Feb 19 2020, 9:34 AM
fgiunchedi changed the status of subtask T219924: Move mobileapps logging to new logging pipeline from Open to Stalled.Mar 9 2020, 11:53 AM
fgiunchedi changed the status of subtask T219925: Move proton logging to new logging pipeline from Open to Stalled.
fgiunchedi moved this task from Inbox to In progress on the observability board.Mar 16 2020, 2:23 PM
akosiaris added a subtask: T239459: service-runner apps running on kubernetes emit logs with log level 50 .Apr 15 2020, 4:58 PM
fgiunchedi moved this task from In progress to Radar on the observability board.Apr 27 2020, 3:15 PM
akosiaris closed subtask T219921: Move cxserver logging to new logging pipeline as Resolved.May 5 2020, 1:50 PM
fgiunchedi mentioned this in T222377: Move kartotherian/tilerator logging to new logging pipeline.Jun 5 2020, 2:05 PM
fgiunchedi closed subtask T219924: Move mobileapps logging to new logging pipeline as Resolved.Sep 7 2020, 4:44 PM
fgiunchedi closed subtask T219925: Move proton logging to new logging pipeline as Resolved.Sep 10 2020, 3:26 PM
fgiunchedi closed subtask T219919: Move citoid logging to new logging pipeline as Resolved.Oct 5 2020, 2:13 PM
MSantos closed subtask T222377: Move kartotherian/tilerator logging to new logging pipeline as Resolved.Nov 24 2020, 6:23 PM
fgiunchedi reopened subtask T222377: Move kartotherian/tilerator logging to new logging pipeline as Open.Nov 25 2020, 8:26 AM
fgiunchedi closed subtask T222377: Move kartotherian/tilerator logging to new logging pipeline as Resolved.Dec 1 2020, 1:33 PM
akosiaris closed subtask T239459: service-runner apps running on kubernetes emit logs with log level 50 as Resolved.Jan 13 2021, 3:49 PM
Aklapper removed a project: Patch-For-Review.May 25 2021, 8:49 PM

@Pchelolo: Hi, all related patches in Gerrit have been merged or abandoned. Is there more to do in this task? Asking as you are set as task assignee. Thanks!

Pchelolo closed this task as Resolved.May 25 2021, 8:50 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL