Page MenuHomePhabricator
Create Task
Maniphest T211133

WikibaseMediaInfo needs a basic integration test suite asap
Closed, ResolvedPublic
Actions

Description

We need a basic integration test suite for WBMI so we know when a dependency change has broken it

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add WikibaseMediaInfo to gated extensionsJforresterintegration/configmaster+2 -0
Add an integration test setCparlemediawiki/extensions/WikibaseMediaInfomaster+245 -0
Customize query in gerrit

Related Objects

Event Timeline

Cparle created this task.Dec 4 2018, 5:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2018, 5:53 PM
Cparle added projects: Multimedia, Multimedia-Team-Working-Board, Structured Data Engineering.Dec 4 2018, 5:53 PM
Cparle updated the task description. (Show Details)
Jdforrester-WMF added a project: Technical-Debt.Dec 4 2018, 8:00 PM
gerritbot subscribed.Dec 7 2018, 5:04 PM

Change 478226 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Integration tests

https://gerrit.wikimedia.org/r/478226

gerritbot added a project: Patch-For-Review.Dec 7 2018, 5:04 PM
Cparle mentioned this in rEWBIe72125f48d11: Integration tests.Dec 7 2018, 5:10 PM
Cparle mentioned this in rEWBI64669cab0d88: Integration tests.Dec 7 2018, 5:20 PM
Cparle mentioned this in rEWBI03a3d4fd18d6: Integration tests.Dec 7 2018, 5:32 PM
Jdforrester-WMF mentioned this in rEWBIf3d9d1288353: Integration tests.Dec 7 2018, 7:29 PM
Jdforrester-WMF mentioned this in rEWBI7d241fa2ca0c: Add an integration test set.Dec 7 2018, 7:40 PM
Jdforrester-WMF moved this task from To Do to Doing on the Structured Data Engineering board.Dec 10 2018, 4:11 PM
Cparle moved this task from To Do to Code Review on the Multimedia-Team-Working-Board board.Dec 10 2018, 5:02 PM
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Dec 17 2018, 11:19 PM
Jdforrester-WMF mentioned this in rEWBIb527b2b2ac9b: Add an integration test set.Dec 18 2018, 10:38 AM
gerritbot added a comment.Dec 18 2018, 12:24 PM

Change 478226 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Add an integration test set

https://gerrit.wikimedia.org/r/478226

Jdforrester-WMF moved this task from Doing to Verify on Production on the Structured Data Engineering board.Dec 18 2018, 12:48 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

Last step is to insert WBMI into the general gate, which I'll get done later today, but this as-written is now done.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 18 2018, 1:01 PM
Cparle added a comment.Jan 17 2019, 12:57 PM

@Jdforrester-WMF did you ever succeed in doing this?

gerritbot added a comment.Jan 17 2019, 7:49 PM

Change 480463 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] Add WikibaseMediaInfo to gated extensions

https://gerrit.wikimedia.org/r/480463

gerritbot added a project: Patch-For-Review.Jan 17 2019, 7:49 PM
Jdforrester-WMF added a comment.Jan 17 2019, 7:50 PM
In T211133#4887923, @Cparle wrote:

@Jdforrester-WMF did you ever succeed in doing this?

Nope, patch written but not deployed. Will ping.

Cparle added a comment.Feb 7 2019, 11:50 AM

@Jdforrester-WMF - any updates?

Jdforrester-WMF added a comment.Feb 7 2019, 8:02 PM
In T211133#4934445, @Cparle wrote:

@Jdforrester-WMF - any updates?

Everyone agrees how to test my patch, they're just not landing it yet. :-(

Jdforrester-WMF mentioned this in T204252: Have dependencies of gated extensions in the gate.Feb 12 2019, 6:32 PM
Jdforrester-WMF moved this task from Verify on Production to Deployment/Config on the Structured Data Engineering board.Feb 19 2019, 1:02 PM

(Moved this to the deployment column as it's waiting for manual deployment by a RelEnger, and isn't waiting for sign-off.)

MBinder_WMF added a project: Structured-Data-Team-Current-Work.Mar 7 2019, 11:51 PM
MBinder_WMF moved this task from To Do to Deployment/Config on the Structured-Data-Team-Current-Work board.
gerritbot added a comment.Apr 11 2019, 6:17 PM

Change 480463 had a related patch set uploaded (by Reedy; owner: Jforrester):
[integration/config@master] Add WikibaseMediaInfo to gated extensions

https://gerrit.wikimedia.org/r/480463

gerritbot added a comment.Apr 11 2019, 6:19 PM

Change 480463 merged by jenkins-bot:
[integration/config@master] Add WikibaseMediaInfo to gated extensions

https://gerrit.wikimedia.org/r/480463

Jdforrester-WMF closed this task as Resolved.Apr 11 2019, 6:25 PM
Jdforrester-WMF removed a project: Patch-For-Review.

This is now live. Thanks, Reedy!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits