(filing a task for work that Ed has already done to flag it for review and QA)
We should make it possible for VE plugins to handle save errors generated by extensions. Currently we have custom code to handle ConfirmEdit (CAPTCHA), SpamBlacklist and AbuseFilter errors.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Esanders | T141676 Move ConfirmEdit-related code out of VisualEditor-MediaWiki and into the ConfirmEdit extension | |||
| Resolved | Esanders | T136859 Provide a system in VisualEditor-MediaWiki to properly integrate CAPTCHAs | |||
| Resolved | Esanders | T211242 Move TitleBlacklist error handling code from VE to TitleBlacklist | |||
| Resolved | Esanders | T211157 Allow VE plugins to handle save errors generated by extensions |
I think the work on this was triggered by a third-party patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/474619 "Support recaptcha for visual editor" – while we were kind of unhappy about having code to handle the CAPTCHA used on Wikimedia wikis in VE, also adding the code to support Google's reCAPTCHA was completely out of the question (on Wikimedia wikis, we don't want to load code that calls out to other sites, even if we don't use it, since that would make it too easy to accidentally enable it and violate our privacy policy). So Ed worked on the framework to allow that code to be written in the extension rather than in VE.
Relevant patches, chronologically:
(patches in each row were dependent on each other and merged at the same time)
| mw/ext/VisualEditor | mw/ext/ConfirmEdit | mw/ext/SpamBlacklist | mw/ext/AbuseFilter |
|---|---|---|---|
| 7bd58c52a5ba: Move extension save error handlers into a registry | |||
| f0295ee01c4c: Remove captcha handler, moved to ConfirmEdit extension | 1f0d20306551: Move VE's ConfirmEdit support to this extension | ||
| 041e7b77a1cb: Create SaveErrorHandler class to better define structure | 057db3d77ade: VE: Convert to SaveErrorHandler | ||
| 103a34bb7558: Remove AbuseFilter & SpamBlacklist code | 687106d8af6b: Bring in VE support from VE extension | 02ada1b4f258: Move in VE support code from the VE extension | |
We should also follow-up on the fact we have a bunch of hard-coded events in ArticleTargetEvents that we use for tracking (e.g. saveErrorCaptcha)
QA notes: try to make an edit that will fail to save because of an error generated by ConfirmEdit (CAPTCHA) / SpamBlacklist / TitleBlacklist / AbuseFilter; make sure the error is shown correctly (as before).