Change 483029 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Inroduce the AMC opt-in toggle and base AMC classes

https://gerrit.wikimedia.org/r/483029

I see @alexhollender revised the mock on Friday. I've reverted to the old mock as this is a big scope increase, and will talk about it on T210653

@Jdlrobson @pmiazga apologies for the switch up / sneak attack here. When we initially discussed the idea of an incremental/progressive AMC release I mentioned that one counter-balance I'd like is an explicit call-out on the settings page to let users know what we're up to, roughly what's coming, and a place to submit feedback. I should've explicitly mentioned to y'all that I was following through with that idea here, with these updated mocks. It sounds like we've got things sorted now.

Change 484729 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Feature management should be aware of user modes

https://gerrit.wikimedia.org/r/484729

Change 483029 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Introduce the AMC opt-in toggle and base AMC classes

https://gerrit.wikimedia.org/r/483029

Change 485075 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] The AMC Mode should be available only in mobile mode

https://gerrit.wikimedia.org/r/485075

Change 485075 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] The AMC Mode should be available only in mobile mode

https://gerrit.wikimedia.org/r/485075

The AMC toggle seems to be working great! Please note: the mocks in the description of this task are currently outdated (but I didn't want to swap in the new ones for the sake of posterity). Please refer to T214195 when making any further design changes to the settings page.

Worked with Piotr and we were able to test the first 4 items in the acceptance criteria and verified they worked as described on:

OS: macOS Mojave 10.14.1
Browser: Safari 12.0.1

The 4th item will need to be verified by an engineer. I can retest in Chrome if requested.

FeaturesManager::isFeatureAvailableInContext will need to be updated to take a $user object and check the stored value of AMC

@pmiazga this work is incomplete since https://gerrit.wikimedia.org/r/484729 is still open...

Change 484729 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Feature management should be aware of user modes

https://gerrit.wikimedia.org/r/484729

Seems like the last two acceptance criteria need to be tested by an engineer (and perhaps someone other than @pmiazga)

@ovasileva, Just in case my network continues misbehaving during today's standup, I think (and @phuedx agrees) that it would be helpful for me to work with the engineer for verifying the 5th acceptance criteria (When a user opts in to (or out of) the AMC mode we need to ensure it is logged and compatible with Schema:PrefUpdate in WikimediaEvents ...we also get T212516 fixed for free!). If @Jdlrobson is up for it we can do a hangout later today.

In T211197#4934897, @Edtadros wrote:

@ovasileva, Just in case my network continues misbehaving during today's standup, I think (and @phuedx agrees) that it would be helpful for me to work with the engineer for verifying the 5th acceptance criteria (When a user opts in to (or out of) the AMC mode we need to ensure it is logged and compatible with Schema:PrefUpdate in WikimediaEvents ...we also get T212516 fixed for free!). If @Jdlrobson is up for it we can do a hangout later today.

Sounds good to me!

☝️ I pulled out the very technical AC from the AC section and into the Developer notes section as:

• It's something that neither @ovasileva and @Edtadros can verify easily; and
• It should probably have been verified during code design and review.

FeaturesManager::isFeatureAvailableInContext will need to be updated to take a User object and check the stored value of AMC. This is needed for the talk tab task (T212216).

As stated, this isn't done. AIUI this does actually work in practice /cc @pmiazga

FeaturesManager::isFeatureAvailableInContext will go away, there were no changes to the isFeatureAvailableInContext, only deprecation. It's deprecated because Minerva is still using it, after we're done with Minerva changes we should be able to remove isFeatureAvailableInContext method.

Test Result (Acceptance Criteria 1-4 of 5)

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator

1. Toggle is on the mobile settings page for logged in users server and client side
2. For anonymous users, no toggle appears server or client side
3. The feature is available as a separate setting (not a part of beta)
4. When opting into the new mode page reloads.

Test Artifact(s):

AC 1:

A logged in user will see the following:

AC 2:

An anonymous in user will see the following:

AC 3:

Please see AC 1 and AC2. Both images show that the toggle doesn't appear in the Beta section.

AC 4:

The page reloads when opting in and opting out. Below is a screenshot of opting in.

@Edtadros and I worked through testing the 4th 5th acceptance criterion together during our 1:1 today.

Here's are the server-side EventLogging events that I captured while opting in and out of AMC mode on http://reading-web-staging.wmflabs.org/wiki/Special:MobileOptions:

Opt in

{
  "event": {
    "property": "mf_amc_optin",
    "value": "\"1\"",
    "isDefault": false,
    "version": "1",
    "userId": 1,
    "saveTimestamp": "20190213173528"
  },
  "schema": "PrefUpdate",
  "revision": 5563398,
  "clientValidated": true,
  "wiki": "wiki",
  "webHost": "reading-web-staging.wmflabs.org",
  "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36"
}

Opt out

{
  "event": {
    "property": "mf_amc_optin",
    "value": "\"0\"",
    "isDefault": true,
    "version": "1",
    "userId": 1,
    "saveTimestamp": "20190213173533"
  },
  "schema": "PrefUpdate",
  "revision": 5563398,
  "clientValidated": true,
  "wiki": "wiki",
  "webHost": "reading-web-staging.wmflabs.org",
  "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36"
}

When a user opts in to (or out of) the AMC mode we need to ensure it is logged and compatible with Schema:PrefUpdate in WikimediaEvents per T212516.

To the "and compatible" part of the AC: note well the "clientValidated": true in the events above.

In T211197#4951773, @phuedx wrote:

@Edtadros and I worked through testing the 4th 5th acceptance criterion together during our 1:1 today.

Here's are the server-side EventLogging events that I captured while opting in and out of AMC mode on http://reading-web-staging.wmflabs.org/wiki/Special:MobileOptions:

[...]

To the "and compatible" part of the AC: note well the "clientValidated": true in the events above.

Thanks! This looks good enough for now, although it still seems worthwhile to run a query later - as soon as this is live in production - to verify that these events show up in the PrefUpdate EL table in Hive or MariaDB. (IIRC events from reading-web-staging are not logged there, correct?)

In T211197#4970337, @Tbayer wrote:

In T211197#4951773, @phuedx wrote:

@Edtadros and I worked through testing the 4th 5th acceptance criterion together during our 1:1 today.

Here's are the server-side EventLogging events that I captured while opting in and out of AMC mode on http://reading-web-staging.wmflabs.org/wiki/Special:MobileOptions:

[...]

To the "and compatible" part of the AC: note well the "clientValidated": true in the events above.

Thanks! This looks good enough for now, although it still seems worthwhile to run a query later - as soon as this is live in production - to verify that these events show up in the PrefUpdate EL table in Hive or MariaDB. (IIRC events from reading-web-staging are not logged there, correct?)

Done - we are seeing plausible-looking events after today's deployment (T217643):

SELECT * FROM event.prefupdate WHERE year = 2019 AND month = 3 AND day >= 20 AND event.property = 'mf_amc_optin' LIMIT 1000;
...
Time taken: 1.596 seconds, Fetched: 7 row(s)

Note though that there seem to be some general concerns about the data quality of the PrefUpdate schema, regarding duplicate events. I have filed T218835 for this. Right now it seems that this problem could be limited to a small number of other preferences (i.e. not the AMC one we're relying on here), but it seems worth checking this later after a larger number of signups have occurred.

Test Result: Production

Status: ✅ PASS
OS: iOS
Browser: Chrome for iOS

Test Artifact(s)/Step(s):

Test Artifact(s):

AC 1: Toggle is on the mobile settings page for logged in users server and client side

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC 2: For anonymous users, no toggle appears server or client side

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC 3:The feature is available as a separate setting (not a part of beta)

Please see AC1 and AC2. Both images show that the toggle doesn't appear in the Beta section.

AC 4: When opting into the new mode page reloads.

The page reloads when opting in and opting out.

@ovasileva This is tested and Passed.