Wow never knew CodeMirror supported this.. impressive. (cmd instead of ctrl on MacOSX btw).

Not sure if this can be supported, as jQuery.textSelection only supports a single selection.

The current CodeMirror 6 integration does not support multiple selections any more. Do we want to add this functionality back with allowMultipleSelections and drawSelection?

In T211205#9475403, @Bhsd wrote:

The current CodeMirror 6 integration does not support multiple selections any more. Do we want to add this functionality back with allowMultipleSelections and drawSelection?

Yes, especially if it existed before. I, like TheDJ, was not even aware of this! CM6 says there's a performance impact, but it seems fine at first glance. If it becomes a problem, we can always remove it. Patch incoming :)

This still won't fix the bug mentioned here, however, as per T211205#4806060 our jQuery.textSelection implementation doesn't support more than one selection :(

Change 1003103 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirrorWikiEditor: add ext for multiple selections/cursors

https://gerrit.wikimedia.org/r/1003103

Change 1003103 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorWikiEditor: add extension for multiple selections/cursors

https://gerrit.wikimedia.org/r/1003103

For now, how about deselecting all secondary selections whenever replaceSelection is called? For example,

this.view.dispatch({
    selection: {
        anchor: this.view.state.selection.main.from,
        head: this.view.state.selection.main.to
    }
});
this.view.dispatch(
    this.view.state.replaceSelection(value)
);

Actually, it looks like CodeMirror just never implemented the encapsulateSelection method. I'm working on adding this now :)

In T211205#9548991, @MusikAnimal wrote:

Actually, it looks like CodeMirror just never implemented the encapsulateSelection method.

I think the problem is more than encapsulateSelection as the WikiEditor toolbar also has a functionality of regexp replacement.

Change 1003927 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirror: partially implement jquery.textSelection 'encapsulateText'

https://gerrit.wikimedia.org/r/1003927

So, the core jQuery.textSelection implementation of encapsulateText applies its changes using replaceSelection etc., which CodeMirror already listens to. As was already pointed out, jQuery.textSelection does not support multiple cursors/selections, so of course it's not doing the right thing either (multiple cursors can exist natively, at least on Firefox/Ubuntu.) I began to think this was then a jQuery.textSelection issue, but it seems there's no standard to be said of for multiple cursors ala a JavaScript API, so something like CodeMirror is required for it to work given CM does the selections itself.

The above patch adds support, but I still wonder if there's some work that could be done in jQuery.textSelection.

In T211205#9549225, @Bhsd wrote:

I think the problem is more than encapsulateSelection as the WikiEditor toolbar also has a functionality of regexp replacement.

Indeed! If my understanding is correct, WikiEditor has some of its own magic as well that interferes with things, but the basic use case of bold/italics and what not should work now. Though I definitely think it's odd that this feature only works in CodeMirror when it comes to multiple cursors.

How is multiple selection meant to work in the case of the link inserter? i.e. follow the above steps but instead of hitting do . With the above patch it's slightly strange, but then it's probably a slightly strange thing to do anyway.

Change 1003927 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirror: partially implement $.textSelection 'encapsulateSelection'

https://gerrit.wikimedia.org/r/1003927

@MusikAnimal Please review below since things changed recently.

Status: ❌FAIL
Environment: Beta: 1.42.0-alpha (b23054d)
OS: macOS Sonoma 14.2.1
Browser: Chrome 122, Firefox 123, Safari 17.3, Edge 122
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.org/w/index.php?title=Wikipedia&action=edit&section=1
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Wikipedia&action=edit
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&action=edit

✅AC1: https://phabricator.wikimedia.org/T211205

Beta	Prod

❌ UPDATE- I'm not sure what happened an hour ago but the results now changed as seen in the webms below as they are all bold. The same results as Italics with Bold.

❓Possible issue with other characters (ex. "å", "œ", "Ω", "∫") -Beta and Prod are the same, not sure if that's fine or not when you try to make these characters bold in code mirror. It added extra characters.

Characters	Beta- Bold	Prod- Bold

@GMikesell-WMF My apologies for the confusion! In order to test CodeMirror 6, you must do one of the following:

• Use any URL (beta or prod) and add the cm6enable=1 URL query string parameter. i.e. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&action=edit&cm6enable=1
  • Note however that as of the time of writing, the code for this task hasn't been deployed to all production wikis yet. I would just do all the testing on Beta for now.
• Use one of the wikis where CodeMirror 6 is currently deployed (T357795):
  • https://simple.wikipedia.beta.wmflabs.org
  • https://he.wikipedia.beta.wmflabs.org
  • https://en-rtl.wikipedia.beta.wmflabs.org

Things are getting more and more stable by the day, so we'll probably deploy to all Beta wikis in the near future.

@MusikAnimal Ok that seems to work. Before I move this to Done, check out the webm for when it's En-rtl.

Status: ❌ FAIL
Environment: Beta: 1.42.0-alpha (d5ff499)
OS: macOS Sonoma 14.2.1
Browser: Chrome 122, Firefox 123, Safari 17.3, Edge 122
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&action=edit&cm6enable=1

✅AC1: https://phabricator.wikimedia.org/T211205

Edge	Firefox	Safari	Chrome	Greek Characters	Section & Link words

Vector 2010	Minveva	Monobook	Timeless

❌AC2: CodeMirror, Bold, En-rtl - Different letters were bold.
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&action=edit&cm6enable=1&uselang=en-rtl

❌AC2: CodeMirror, Bold, En-rtl - Different letters were bold.
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&action=edit&cm6enable=1&uselang=en-rtl

Oh boy. So, I'm seeing a number of issues… I've identified r1005841 (an unrelated patch) as causing a massive performance bottleneck, and I think the issue you're seeing is a side effect of that. I'm guessing the slow render caused the cursor to become offset with the view, or something. I'm investigating.

Oh boy. So, I'm seeing a number of issues… I've identified r1005841 (an unrelated patch) as causing a massive performance bottleneck, and I think the issue you're seeing is a side effect of that. I'm guessing the slow render caused the cursor to become offset with the view, or something. I'm investigating.

Not a performance problem as it turns out, but some other weirdness. Anyway, things should work correctly now!

❌AC2: CodeMirror, Bold, En-rtl - Different letters were bold.
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&action=edit&cm6enable=1&uselang=en-rtl

As an aside, while testing RTL languages on a LTR wiki is great, it doesn't properly test the RTL environment unless the page language is also RTL. So for RTL testing, I would just use https://en-rtl.wikipedia.beta.wmflabs.org/. There you don't need to use the ?cm6enable=1 flag, either. (I'm also going to get CM6 deployed to all of Beta probably today, so soon you won't use the cm6enable parameter at all on Beta).

@MusikAnimal When it's an RTL interface with RTL language,I have no issues. The same goes with LTR. I do get issues when it's RTL interface with LTR language and vice versa which I created a separate task in T359589: CodeMirror 6: Cursor is offset when viewing a mix of LTR/RTL interfaces and page langauge. For this task, I will move this to Done and test the other task created when it has been resolved. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (ab3f8bd)
OS: macOS Sonoma 14.2.1
Browser: Chrome 122, Firefox 123, Safari 17.3, Edge 122
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en-rtl.wikipedia.beta.wmflabs.org/w/index.php?title=I_Started_With_100K&action=edit
https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog#

✅AC1: https://phabricator.wikimedia.org/T211205

Browser + interface in LTR + page language in LTR	Vector 2010	Minerva	Monobook	Timeless

Browser + interface in RTL + page language in RTL	Vector 2010	Minerva	Monobook	Timeless

Safari	Firefox	Edge

In T211205#9613986, @MusikAnimal wrote:

Using it without multiple cursors should be fine, as it uses the jQuery.textSelection which bubbles up to CodeMirror.

Unfortunately, no. The WikiEditor's replace, excluding replaceAll, completely ceases to work. In addition, inserting an image, a template, or a table is not working any more.

In T211205#9614010, @Bhsd wrote:

The WikiEditor's replace, excluding replaceAll, completely ceases to work. In addition, inserting an image, a template, or a table is not working any more.

Here I was just making assumptions… thanks for testing! I have filed T359671 and will work on this next.