Page MenuHomePhabricator
Create Task
Maniphest T211242

Move TitleBlacklist error handling code from VE to TitleBlacklist
Closed, ResolvedPublic
Actions

Description

Move TitleBlacklist error handling code from VE to TitleBlacklist, like we did for other extensions (T211157#4799056).

Details

SubjectRepoBranchLines +/-
Remove TitleBlacklist handling codemediawiki/extensions/VisualEditormaster+0 -17
Bring in VE supportmediawiki/extensions/TitleBlacklistmaster+41 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Dec 5 2018, 9:38 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 5 2018, 9:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex triaged this task as Low priority.Dec 5 2018, 9:38 PM
matmarex mentioned this in T211157: Allow VE plugins to handle save errors generated by extensions.
gerritbot subscribed.Dec 6 2018, 8:01 PM

Change 478050 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Remove TitleBlacklist handling code

https://gerrit.wikimedia.org/r/478050

gerritbot added a comment.Dec 6 2018, 8:01 PM

Change 478051 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/TitleBlacklist@master] Bring in VE support

https://gerrit.wikimedia.org/r/478051

gerritbot added a project: Patch-For-Review.Dec 6 2018, 8:01 PM
Jdforrester-WMF added a subtask: T211157: Allow VE plugins to handle save errors generated by extensions.Dec 6 2018, 8:38 PM
matmarex edited projects, added VisualEditor (Current work); removed Patch-For-Review, VisualEditor.Dec 7 2018, 6:56 PM
matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Dec 7 2018, 7:02 PM

Change 478051 merged by jenkins-bot:
[mediawiki/extensions/TitleBlacklist@master] Bring in VE support

https://gerrit.wikimedia.org/r/478051

gerritbot added a comment.Dec 7 2018, 7:03 PM

Change 478050 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove TitleBlacklist handling code

https://gerrit.wikimedia.org/r/478050

matmarex closed this task as Resolved.Dec 7 2018, 7:35 PM
matmarex assigned this task to Esanders.
matmarex edited projects, added VisualEditor; removed VisualEditor (Current work).

(Let's do Editing team QA/product review on T211157, these are all related.)

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 7 2018, 7:35 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 7 2018, 8:00 PM
• ppelberg closed subtask T211157: Allow VE plugins to handle save errors generated by extensions as Resolved.Sep 3 2019, 12:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL