Page MenuHomePhabricator
Create Task
Maniphest T211267

ORES precaching seem to not understand its own config
Closed, ResolvedPublic
Actions

Description

It seems like the /v3/precache endpoint does not respect it's own configuration. Looking into the deploy repo, the precaching config is:

precache:
  damaging:
    "on": ["edit"]
  drafttopic:
    "on": ["page_creation"]
  goodfaith:
    "on": ["edit"]

However, if I manually post an event for a page creation to the endpoint, the result only contains goodfaith model and not the two others.

Additionally, for page creation is does not quite work at all - it expects the rev_parent_id to be NULL, if it's undefined it fails with a 400.

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Dec 6 2018, 12:48 AM
• Pchelolo triaged this task as Medium priority.
• mobrovac added a project: Platform Team Legacy (Watching / External).Dec 6 2018, 10:59 AM
Ladsgroup claimed this task.Dec 10 2018, 2:24 PM
Ladsgroup edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.

I will pick this up this Thursday. Sorry I can't do it sooner (team offsite, conference, etc.)

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 10 2018, 2:24 PM
Ladsgroup added a comment.Dec 13 2018, 2:54 PM

I found it what's wrong. Will fix it and deploy it ASAP.

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Dec 13 2018, 3:20 PM

https://github.com/wikimedia/ores/pull/300

Ladsgroup mentioned this in rORES9448011c6492: Fix parsing of precache config.Dec 13 2018, 3:30 PM
Stashbot subscribed.Dec 13 2018, 5:32 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-13T17:32:02Z] <ladsgroup@deploy1001> Started deploy [ores/deploy@1a3de73]: T211267

Stashbot added a comment.Dec 13 2018, 5:45 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-13T17:45:55Z] <ladsgroup@deploy1001> Finished deploy [ores/deploy@1a3de73]: T211267 (duration: 13m 53s)

Ladsgroup moved this task from Review to Parked on the Machine-Learning-Team (Active Tasks) board.Dec 13 2018, 5:47 PM

The 400 issue is not resolved yet. Will work on it tomorrow.

Halfak renamed this task from ORES preaching seem to not understand it's own config to ORES precaching seem to not understand it's own config.Dec 13 2018, 8:05 PM
• mobrovac renamed this task from ORES precaching seem to not understand it's own config to ORES precaching seem to not understand its own config.Dec 14 2018, 11:51 AM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Dec 14 2018, 4:32 PM

https://github.com/wikimedia/ores/pull/302/files

Ladsgroup mentioned this in rORES2129c1056691: Make check for parent rev in precache more robust to change.Dec 14 2018, 4:32 PM
Stashbot mentioned this in T206333: Change default serializer of celery from pickle to json.Dec 17 2018, 11:48 AM

Mentioned in SAL (#wikimedia-operations) [2018-12-17T11:48:20Z] <ladsgroup@deploy1001> Started deploy [ores/deploy@18d3657]: T206333 T211267

Stashbot added a comment.Dec 17 2018, 12:02 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-17T12:02:34Z] <ladsgroup@deploy1001> Finished deploy [ores/deploy@18d3657]: T206333 T211267 (duration: 14m 14s)

Ladsgroup closed this task as Resolved.Dec 17 2018, 12:33 PM
Ladsgroup moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.

The second part is also done:

image.png (176×1 px, 14 KB)

(Ignore the spike, everything after that went to zero)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits