Page MenuHomePhabricator

Rename chromium-render gerrit project to Proton
Closed, DeclinedPublic

Description

The PDF rendering project is named everywhere Proton, but the gerrit project is chromium-render. To be consistent (and make everyone's life easier) we should rename the project to proton.

Event Timeline

pmiazga created this task.Dec 6 2018, 8:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2018, 8:56 PM
Peachey88 renamed this task from Rename chromium-render project to Proton to Rename chromium-render gerrit project to Proton.Dec 7 2018, 9:16 AM
Peachey88 added a project: Gerrit.
Peachey88 moved this task from Bugs & stuff to Repo Admin on the Gerrit board.
ovasileva triaged this task as High priority.Dec 7 2018, 12:31 PM
Jdlrobson assigned this task to pmiazga.Dec 11 2018, 5:48 PM
Jdlrobson added a subscriber: Jdlrobson.

Gerrit renames are quite painful in my experience. We'd also lose git history right? Is this worth it @pmiazga it's not clear to me from the description that this trade off has been considered. Can you also update the description with the expected steps that will be required to do this?

For instance Popups extension never got renamed (although I imagine renaming extensions is more complicated than services).

You won't loose git history if you create the new repo and then git mirror the old repo to the new repo :).

I would advise against this. Apart from gerrit pains with renames, this would also involve changing all of our puppet code surrounding proton. I really think we should keep it as-is, especially now that the service is already in production.

Jdlrobson lowered the priority of this task from High to Normal.Dec 12 2018, 10:49 PM
hashar added a subscriber: hashar.Dec 19 2018, 3:06 PM

Should the task just be declined based on @mobrovac comment? Not sure whether it is worth all the overhead.

Jhernandez closed this task as Declined.Dec 19 2018, 4:43 PM
Jhernandez added a subscriber: Jhernandez.

Declined for now, given the comments. We will revisit later