Page MenuHomePhabricator
Create Task
Maniphest T211438

Cannot undo Sense addition
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Problem:
Trying to undo a revision which added a new Sense does not work (for example undoing revision 806936938 ). Attempting to undo it or restore its parent revision will appear to succeed, but have no effect.

Acceptance criteria:

  • Sense additions can be undone
  • The parent revision of a Sense addition can be restored
  • Add an undo test for this case in LexemeEditPageTest

Details

SubjectRepoBranchLines +/-
Cleanup commented out tests in LexemeSensesMergerTestmediawiki/extensions/WikibaseLexememaster+3 -53
Bug, Make Lexeme::equals actually check senses & testmediawiki/extensions/WikibaseLexememaster+218 -13
Add LexemeEditPageTest::testSenseAdditionUndomediawiki/extensions/WikibaseLexememaster+36 -0
Customize query in gerrit

Revisions and Commits

rEWLE extension-WikibaseLexeme
rEWLEd400c9d561cb Bug, Make Lexeme::equals actually check senses & test

Related Objects

Event Timeline

LucasWerkmeister created this task.Dec 7 2018, 5:32 PM
Lydia_Pintscher triaged this task as High priority.Jan 4 2019, 11:51 AM
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.
Lydia_Pintscher added a project: Wikidata-Campsite.
Lydia_Pintscher moved this task from incoming to features/bugs for next release (Lexeme page) on the Wikidata Lexicographical data board.
Lydia_Pintscher subscribed.

I just tested if it works for Forms and there it seems fine. It is indeed broken for Senses.

Lydia_Pintscher renamed this task from Cannot undo sense addition to Cannot undo Sense addition.Jan 6 2019, 5:53 PM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore set the point value for this task to 8.Jan 8 2019, 2:23 PM
Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore updated the task description. (Show Details)Jan 8 2019, 2:52 PM
Addshore claimed this task.Jan 8 2019, 4:03 PM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 8 2019, 4:03 PM
gerritbot subscribed.Jan 8 2019, 4:38 PM

Change 482837 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Add LexemeEditPageTest::testSenseAdditionUndo

https://gerrit.wikimedia.org/r/482837

gerritbot added a project: Patch-For-Review.Jan 8 2019, 4:38 PM
Addshore mentioned this in rEWLE93e5eff12e37: Add LexemeEditPageTest::testSenseAdditionUndo.Jan 8 2019, 4:44 PM
Addshore mentioned this in rEWLE2767e336e49f: Add LexemeEditPageTest::testSenseAdditionUndo.
Addshore mentioned this in rEWLEd14f85f60f3b: Add LexemeEditPageTest::testSenseAdditionUndo.Jan 8 2019, 4:59 PM
gerritbot added a comment.Jan 8 2019, 5:09 PM

Change 482843 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Bug, Make Lexeme::equals actually check senses & test

https://gerrit.wikimedia.org/r/482843

Addshore moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 8 2019, 5:09 PM
Addshore moved this task from consider for next sprint to in progress on the Wikidata board.
Addshore mentioned this in rEWLE69f889526163: Add LexemeEditPageTest::testSenseAdditionUndo.Jan 8 2019, 5:21 PM
gerritbot added a comment.Jan 9 2019, 4:43 AM

Change 482837 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add LexemeEditPageTest::testSenseAdditionUndo

https://gerrit.wikimedia.org/r/482837

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 9 2019, 5:00 AM
gerritbot added a comment.Jan 9 2019, 9:14 AM

Change 483068 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Cleanup commented out tests in LexemeSensesMergerTest

https://gerrit.wikimedia.org/r/483068

Addshore mentioned this in rEWLEe9f9c6ee4639: Cleanup commented out tests in LexemeSensesMergerTest.Jan 9 2019, 9:20 AM
gerritbot added a comment.Jan 9 2019, 12:16 PM

Change 482843 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Bug, Make Lexeme::equals actually check senses & test

https://gerrit.wikimedia.org/r/482843

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 9 2019, 12:16 PM
Addshore closed this task as Resolved by committing rEWLEd400c9d561cb: Bug, Make Lexeme::equals actually check senses & test.Jan 9 2019, 12:19 PM
Addshore added a commit: rEWLEd400c9d561cb: Bug, Make Lexeme::equals actually check senses & test.
Addshore reopened this task as Open.Jan 9 2019, 12:20 PM

I somehow managed to trigger some magical phabricator diffusion stuff there that closed this task automagically......

Lydia_Pintscher closed this task as Resolved.Jan 10 2019, 8:45 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/

Addshore mentioned this in rEWLEa054769368a1: Cleanup commented out tests in LexemeSensesMergerTest.Jan 11 2019, 3:58 PM
JeroenDeDauw mentioned this in rEWLE2e9a0da0a6a5: Cleanup commented out tests in LexemeSensesMergerTest.Jan 15 2019, 8:17 AM
gerritbot added a comment.Jan 17 2019, 5:47 PM

Change 483068 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Cleanup commented out tests in LexemeSensesMergerTest

https://gerrit.wikimedia.org/r/483068

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.14; 2019-01-22); removed MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 17 2019, 6:00 PM
jijiki mentioned this in rEWLEcaf1d99c3e24: Cleanup commented out tests in LexemeSensesMergerTest.Mar 18 2019, 4:36 PM
jijiki mentioned this in rEWLEc91fe4a05381: Add LexemeEditPageTest::testSenseAdditionUndo.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL