Login page doesn't show issues before submission (mediawiki.special.userlogin.signup.js does not define the mobile target)
Open, LowPublic
Actions

Description

On desktop if a user provides an invalid password (e.g. password) the error message displays via AJAX. On mobile web the error(s) display after submit:

Consider displaying the errors before submission on mobile web.

Developer notes

The resourceloader module mediawiki.special.userlogin.signup.js has not been enabled on mobile domain. It can be seen running on Minerva here: https://en.wikipedia.org/w/index.php?title=Special:CreateAccount&campaign=loginCTA&useskin=minerva

When enabling we'll also want to take the time to add the small functionality inside mobile.special.userlogin.scripts in MobileFrontend to core, so that 2 modules are not loaded and the startup module does not expand in size.

It can be added by making mediawiki.special.userlogin.signup.js load on mobile

See:
https://www.mediawiki.org/wiki/ResourceLoader/Writing_a_MobileFrontend_friendly_ResourceLoader_module

Acceptance criteria

Code in mobile.special.userlogin.scripts inside MobileFrontend has been copied across to mediawiki.special.userlogin.signup.js and scoped to mobile browsers.
mediawiki.special.userlogin.signup.js runs in mobile (targets is set to 'mobile')
mobile.special.userlogin.scripts ResourceLoader module removed from MobileFrontend

Related Objects

Mentioned In: W2253 Tasks
T207787: [EPIC] Reduce the amount of modules in MobileFrontend
T211514: $wgPasswordPolicy should be able to alter the password form field
T208246: Change password length requirement and ensure enforcement for privileged users (from 8 to 10)
T211440: Consider displaying a tooltip by the password input field to explain password requirements

Event Timeline

TBolliger created this task.Dec 7 2018, 5:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2018, 5:45 PM

TBolliger mentioned this in T211440: Consider displaying a tooltip by the password input field to explain password requirements.Dec 7 2018, 5:51 PM

TBolliger mentioned this in T208246: Change password length requirement and ensure enforcement for privileged users (from 8 to 10).Dec 7 2018, 5:59 PM

Tgr mentioned this in T211514: $wgPasswordPolicy should be able to alter the password form field.Dec 9 2018, 7:51 PM

pmiazga added a project: Readers-Web-Backlog.Dec 11 2018, 10:30 PM

pmiazga moved this task from Needs triage to Triaged on the Mobile board.Dec 11 2018, 10:41 PM

Jdlrobson renamed this task from Consider displaying password errors on mobile web account creation before submission to mediawiki.special.userlogin.signup.js does not define the mobile target so doesn't show issues before submission.Dec 12 2018, 12:29 AM

Jdlrobson edited projects, added Readers-Web-Backlog (Design); removed Readers-Web-Backlog, MobileFrontend.

Jdlrobson updated the task description. (Show Details)

MobileFrontend shows the login/signup page that lives in mediawiki/core so nothing relating to MobileFrontend here.
It's just a case of verifying and turning on the code:

@alexhollender from a design perspective what would need to change in the presentation of these errors? (see above)

Jdlrobson raised the priority of this task from Low to Needs Triage.Dec 12 2018, 1:02 AM

Jdlrobson moved this task from To Triage to Design on the Readers-Web-Backlog board.Dec 12 2018, 1:16 AM

Jdlrobson edited projects, added Readers-Web-Backlog (Design); removed Readers-Web-Backlog.

@Jdlrobson how can I try this out on mobile? I went to https://en.wikipedia.org/w/index.php?title=Special:CreateAccount&campaign=loginCTA&useskin=minerva but the experience seemed to be the same as what's currently in production (i.e. I'm not seeing inline error messages like there are in the GIF in the description)

@RHo @MMiller_WMF this isn't very high priority from our perspective, but perhaps something y'all would be interested in working on? Happy to toss it over to you

Thanks, @alexhollender. I'll add tag our team on this. This issue is occurring higher up in the funnel than where our team is currently focused, so it is probably not something we would address very soon. We're focused on the thousands of people who have successfully created their account, but still don't edit. We may move up the funnel later on.

Jdlrobson updated the task description. (Show Details)Jan 3 2019, 12:24 AM

Jdlrobson mentioned this in T207787: [EPIC] Reduce the amount of modules in MobileFrontend.Jan 3 2019, 12:34 AM

Catrope moved this task from Inbox to Needs Discussion/Analysis on the Growth-Team board.Jan 8 2019, 2:13 AM

Catrope moved this task from Needs Discussion/Analysis to Q2 2019-20 on the Growth-Team board.Jan 11 2019, 11:51 PM

Jdlrobson moved this task from Backlog to Bugs on the MinervaNeue board.Feb 5 2019, 6:53 PM

Jdlrobson moved this task from Bugs to Tech debt on the MinervaNeue board.

SBisson mentioned this in W2253 Tasks.Apr 4 2019, 12:35 PM

The Growth team is considering this task for the hackathon. We're happy to collaborate with other participants on this.

SBisson edited projects, added Wikimedia-Hackathon-2019; removed Wikimania-Hackathon-2019.Apr 4 2019, 7:17 PM

SBisson moved this task from Backlog to Projects on the Wikimedia-Hackathon-2019 board.Apr 4 2019, 7:19 PM

Tgr added a subscriber: Tgr.May 15 2019, 5:40 PM

JTannerWMF moved this task from Q2 2019-20 to Q1 2019-20 on the Growth-Team board.Mon, Jun 17, 6:52 PM

Login page doesn't show issues before submission (mediawiki.special.userlogin.signup.js does not define the mobile target)Open, LowPublicActions