Page MenuHomePhabricator
Create Task
Maniphest T211444

Scraped description text of images shows remnants of CSS transforms in MediaViewer
Closed, ResolvedPublic
Actions

Description

https://en.wikipedia.org/wiki/Scotland#/media/File:Scotland_in_the_UK_and_Europe.svg renders the description as:

Location of  .mw-parser-output .nobold{font-weight:normal}Scotland  (dark green) – in Europe  (green & dark grey) – in the United Kingdom  (green)

… instead of "Location of Scotland (dark green) – in Europe (green & dark grey) – in the United Kingdom (green)". The extra spaces and class are generated from https://en.wikipedia.org/wiki/Template:Infobox_country_UK as:

map_caption = {{{map_caption|{{map caption |location_color=dark green|country={{nobold|{{{common_name|{{PAGENAME}}}}}}} |subregion=the [[United Kingdom]] |subregion_color=green |region=Europe|region_color=dark grey}}}}}

… and these are leaking out.

Details

SubjectRepoBranchLines +/-
Use innerText instead of .text() to get descriptionmediawiki/extensions/MobileFrontendmaster+4 -3
Ignore TemplateStyle-generated content when textifying HTMLmediawiki/extensions/MultimediaViewermaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Dec 7 2018, 7:09 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptDec 7 2018, 7:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr removed a project: PageImages.Dec 7 2018, 7:28 PM
Tgr subscribed.

Seems unrelated to PageImages. It's caused by TemplateStyles but not a problem with that component either, MMV just needs to be more intelligent about HTML parsing.

gerritbot subscribed.Dec 7 2018, 7:29 PM

Change 478247 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/MultimediaViewer@master] Ignore TemplateStyle-generated content when textifying HTML

https://gerrit.wikimedia.org/r/478247

gerritbot added a project: Patch-For-Review.Dec 7 2018, 7:29 PM
gerritbot added a comment.Dec 7 2018, 10:45 PM

Change 478247 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Ignore TemplateStyle-generated content when textifying HTML

https://gerrit.wikimedia.org/r/478247

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 7 2018, 11:00 PM
Tgr closed this task as Resolved.Dec 7 2018, 11:55 PM
Tgr claimed this task.

https://en.wikipedia.beta.wmflabs.org/wiki/File:Scotland_in_the_UK_and_Europe.svg#/media/File:Scotland_in_the_UK_and_Europe.svg works now.

Jdforrester-WMF removed a project: Patch-For-Review.Dec 10 2018, 10:58 PM
jhsoby reopened this task as Open.Oct 25 2023, 11:10 AM
jhsoby added a project: MobileFrontend.
jhsoby subscribed.

This is still happening on the mobile site. See attached screenshot I took just now from https://en.m.wikipedia.org/wiki/Ethnic_groups_in_South_Africa#/media/File%3ASouth_Africa_2011_dominant_population_group_map_(hex_cells).svg

It seems to only happen on the mobile site, not the desktop site with ?useskin=minerva: https://en.wikipedia.org/wiki/Ethnic_groups_in_South_Africa?useskin=minerva#/media/File:South_Africa_2011_dominant_population_group_map_(hex_cells).svg
So it might be MobileFrontend interfering somehow?

Screenshot_20231025_130541.png (1×1 px, 433 KB)

gerritbot added a comment.Oct 25 2023, 11:29 AM

Change 968638 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/MobileFrontend@master] Remove style tags from captions in media viewer

https://gerrit.wikimedia.org/r/968638

gerritbot added a project: Patch-For-Review.Oct 25 2023, 11:29 AM
PatchDemoBot added a comment.Nov 27 2023, 10:36 PM

Test wiki created on Patch demo by Jon Harald Søby using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7e04caca21/w

PatchDemoBot added a comment.Nov 27 2023, 10:43 PM

Test wiki created on Patch demo by Jon Harald Søby using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/5218875055/wiki/Ethnic groups in South Africa

PatchDemoBot added a comment.Nov 27 2023, 10:45 PM

Test wiki on Patch demo by Jon Harald Søby using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/7e04caca21/w/

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 12 2024, 11:13 AM
Tgr removed Tgr as the assignee of this task.Apr 15 2024, 2:03 PM
Jdlrobson assigned this task to jhsoby.Apr 15 2024, 7:43 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 2); removed MediaViewer.
Jdlrobson subscribed.

there is a patch for review.

SToyofuku-WMF triaged this task as Medium priority.Apr 18 2024, 5:53 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q4 Sprint 2).Apr 23 2024, 5:25 PM
gerritbot added a comment.May 20 2024, 2:19 PM

Change #968638 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Use innerText instead of .text() to get description

https://gerrit.wikimedia.org/r/968638

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 20 2024, 3:00 PM
Jdlrobson closed this task as Resolved.May 20 2024, 3:38 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 4); removed Web-Team-Backlog.
PatchDemoBot added a comment.May 24 2024, 9:43 PM

Test wiki on Patch demo by Jon Harald Søby using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/5218875055/w/

Edtadros mentioned this in T365385: Verify 1.43.0-wmf.6 deployment.May 28 2024, 10:05 PM
Jdlrobson moved this task from Needs analysis to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 31 2024, 4:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits