Page MenuHomePhabricator
Create Task
Maniphest T211606

As a user of Superset I would like it to be up-to-date so I'm not blocked by bugs that have already been fixed
Closed, DeclinedPublic
Actions

Description

In T210687#4810654, @fdans wrote:

After digging a lil bit, I'm pretty sure this issue was fixed with this change:

https://github.com/apache/incubator-superset/pull/5931

Current version we have is 0.26.3, we should upgrade to 0.28.1.

Since Superset is in such active development and has so many issues due to it being a work-in-progress, I think it makes sense for us to have the upgrades either be automated or at least set some kind of a regular schedule. I'd love for us to have the latest version every week or so rather than…well, there's currently no regular cadence. I think last upgrade was done manually in August (T201430) per a request from me. And now there's T211605 because of T210687

Like, we're putting all our data reporting eggs into this basket and I think it'd be great if that basket wasn't constantly out of date and full of holes that have could have been patched weeks/months ago. We shouldn't have to make a new "update superset" task every single time we encounter an issue that's been fixed upstream and we're just behind.

P.S. This would also help with filing issues upstream because one of the requirements when submitting a bug is that it was replicated on the latest version.

Related Objects

Event Timeline

mpopov created this task.Dec 10 2018, 3:44 PM
mpopov moved this task from Triage to Tracking on the Product-Analytics board.
elukey subscribed.Dec 10 2018, 4:03 PM
elukey added a comment.EditedDec 11 2018, 1:55 PM

We discussed this during the Analytics standup and we have a proposal: we could start with creating a tracking task for Superset/Turnilo upgrade schedules, that everybody can bookmark easily, and then start with one update every quarter (if upstream released a new version of course). If this turns up to be not enough, the same tracking task will also be used to request new versions for specific reasons (like solving a bug etc..). How does it sound?

EDIT: having automatic updates is not feasible at the moment since we have to pack Superset/Turnilo's dependencies and code in debian packages / scap repos.

mpopov added a comment.Dec 11 2018, 2:08 PM

I'll check with the team at our meeting later today and let you know :)

elukey added a comment.Dec 11 2018, 3:52 PM

@mpopov please also keep in mind that things like T211605#4814020 could happen with a project that is still developing fast and does not care much about breaking existing users, so upgrades might not be easy :D

• Tbayer awarded a token.Dec 11 2018, 4:14 PM
• Tbayer subscribed.
• Nuria subscribed.Dec 11 2018, 7:09 PM

@mpopov I have opened a parent task to track super set updates, please see: T211706

In an ideal world updates could be automated but this is less easy than you might think cause to do that superset needs to run in the version of debian that we have and superset folks are kind of fond of releasing backwards incompatible changes, see: https://github.com/apache/incubator-superset/blob/master/UPDATING.md
Regardless, these issues are nothing new on the OS ecosystem we live in. We aim to update superset at the beginning of every quarter which is easy to remember. We can do additional upgrades if needed that will hang from the main parent task. Being on latests and greatest with the amount of changes this project has is not a guarantee of stability, quite the opposite.

Like, we're putting all our data reporting eggs into this basket and I think it'd be great if that basket wasn't constantly out of date and full of holes that have could have been patched weeks/months ago.

We expect that superset will be able to support many of our data reporting needs and we understand you want more promptly upgrades, we hear that. Now, given that superset is been used sparingly despite being available now for over a year it is really not surprising that we do not have a more stream lined process for updates (other than security ones, which happen through other means) . As I said, we will work to correct that.

FYI that we do not expect superset support 100% of our reporting needs, just probably the majority of them.

• Nuria triaged this task as High priority.Dec 12 2018, 8:03 PM
• Nuria moved this task from Incoming to Operational Excellence on the Analytics board.
elukey added a comment.Dec 13 2018, 12:59 PM

@mpopov I added some comments to T211706, let me know what you think about the plan :)

mpopov closed this task as Declined.Dec 13 2018, 4:13 PM
In T211606#4814078, @elukey wrote:

@mpopov please also keep in mind that things like T211605#4814020 could happen with a project that is still developing fast and does not care much about breaking existing users, so upgrades might not be easy :D

That's a good point and we'll keep that in mind! :)

In T211606#4814874, @Nuria wrote:

@mpopov I have opened a parent task to track super set updates, please see: T211706

In an ideal world updates could be automated but this is less easy than you might think cause to do that superset needs to run in the version of debian that we have and superset folks are kind of fond of releasing backwards incompatible changes, see: https://github.com/apache/incubator-superset/blob/master/UPDATING.md
Regardless, these issues are nothing new on the OS ecosystem we live in. We aim to update superset at the beginning of every quarter which is easy to remember. We can do additional upgrades if needed that will hang from the main parent task. Being on latests and greatest with the amount of changes this project has is not a guarantee of stability, quite the opposite.

Sounds good, thank you! I've spoken with the team and we like this approach.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits