Page MenuHomePhabricator
Create Task
Maniphest T211629

WDQS embeds do not display
Closed, ResolvedPublic
Actions

Description

WDQS results do not display properly when embedded.

Examples:
The example query

#defaultView:Map
SELECT * WHERE {
  ?item wdt:P31*/wdt:P279* wd:Q16917;
        wdt:P625 ?geo.
}

displays fine in the WDQS directly but only shows the Wikidata logo when embedded:
https://query.wikidata.org/#%23added%202017-08%0A%23defaultView%3AMap%0ASELECT%20%2a%20WHERE%20%7B%0A%20%20%3Fitem%20wdt%3AP31%2a%2Fwdt%3AP279%2a%20wd%3AQ16917%3B%0A%20%20%20%20%20%20%20%20wdt%3AP625%20%3Fgeo%20.%0A%7D
https://query.wikidata.org/embed.html#%23added%202017-08%0A%23defaultView%3AMap%0ASELECT%20*%20WHERE%20%7B%0A%20%20%3Fitem%20wdt%3AP31*%2Fwdt%3AP279*%20wd%3AQ16917%3B%0A%20%20%20%20%20%20%20%20wdt%3AP625%20%3Fgeo%20.%0A%7D

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Updated GUIHoo manwikidata/query/deploymaster+1 -1
Fix instantiation of ResultView in embed.htmlLucas Werkmeister (WMDE)wikidata/query/guimaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Daniel_Mietchen created this task.Dec 10 2018, 8:45 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptDec 10 2018, 8:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Daniel_Mietchen triaged this task as High priority.Dec 10 2018, 8:46 PM

This could be related to the UI update, as per https://twitter.com/wikimediatech/status/1072190613636952069 .

Smalyshev edited projects, added: Wikidata Query UI; removed: Wikidata-Query-Service.Dec 10 2018, 8:50 PM
Daniel_Mietchen added a comment.Dec 10 2018, 8:56 PM

Here's how this looks like in Scholia (it's a whole-page screenshot which is apparently outsized for Phabricator, so you have to click on the image to actually see it rather than the mystery placeholder image).

Screenshot_2018-12-10 Scholia.png (1,908×9,929 px, 762 KB)

Smalyshev raised the priority of this task from High to Unbreak Now!.Dec 10 2018, 9:15 PM
Smalyshev subscribed.

I see JS error: this._querySamplesApi.getLanguage in not a function. There were some changes related to this recently, so possible there's a breakage.

@Lucas_Werkmeister_WMDE could you take a look?

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptDec 10 2018, 9:15 PM
Fnielsen subscribed.Dec 10 2018, 11:55 PM

"Non-tabular WDQS embeds do not display": Note embedded tables neither works. Embedded tables show the same errror

Daniel_Mietchen renamed this task from Non-tabular WDQS embeds do not display to WDQS embeds do not display.Dec 11 2018, 1:12 AM
Daniel_Mietchen added a comment.Dec 11 2018, 1:14 AM
In T211629#4812463, @Fnielsen wrote:

"Non-tabular WDQS embeds do not display": Note embedded tables neither works. Embedded tables show the same errror

Yep - hadn't checked that before, and renamed the ticket accordingly. The reason some Scholia tables display as usual is that they are built by processing the WDQS results, rather than embedding them directly.

EgonWillighagen subscribed.Dec 11 2018, 8:30 AM
GerardM subscribed.Dec 11 2018, 8:53 AM
Lucas_Werkmeister_WMDE claimed this task.Dec 11 2018, 11:12 AM
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot subscribed.Dec 11 2018, 11:29 AM

Change 478900 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Fix instantiation of ResultView in embed.html

https://gerrit.wikimedia.org/r/478900

gerritbot added a project: Patch-For-Review.Dec 11 2018, 11:29 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 11 2018, 11:29 AM
Lucas_Werkmeister_WMDE mentioned this in rWDQG197b195b5496: Fix instantiation of ResultView in embed.html.Dec 11 2018, 11:32 AM
gerritbot added a comment.Dec 11 2018, 11:36 AM

Change 478900 merged by jenkins-bot:
[wikidata/query/gui@master] Fix instantiation of ResultView in embed.html

https://gerrit.wikimedia.org/r/478900

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 11 2018, 11:49 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 11 2018, 12:03 PM
gerritbot added a comment.Dec 11 2018, 12:38 PM

Change 478921 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[wikidata/query/deploy@master] Updated GUI

https://gerrit.wikimedia.org/r/478921

gerritbot added a comment.Dec 11 2018, 12:38 PM

Change 478921 merged by Hoo man:
[wikidata/query/deploy@master] Updated GUI

https://gerrit.wikimedia.org/r/478921

Stashbot subscribed.Dec 11 2018, 12:39 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-11T12:39:53Z] <hoo@deploy1001> Started deploy [wdqs/wdqs@f914415]: Fix WDQS UI embeds (T211629)

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 11 2018, 12:49 PM
Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Should be fixed now.

Stashbot added a comment.Dec 11 2018, 12:50 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-11T12:50:24Z] <hoo@deploy1001> Finished deploy [wdqs/wdqs@f914415]: Fix WDQS UI embeds (T211629) (duration: 10m 31s)

Salgo60 subscribed.Dec 11 2018, 12:50 PM

Yes thanks now this page works

Daniel_Mietchen awarded a token.Dec 11 2018, 1:05 PM

Thanks!

Liuxinyu970226 unsubscribed.Dec 12 2018, 2:41 PM
Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits