Outbound BGP graceful shutdown
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ayounsi
	Dec 11 2018, 9:49 PM

Description

Thought about it for T211715

This is to be able to smoothly drain traffic before disabling the BGP session/interface to a providers that support BGP graceful shutdown (eg. NTT, Telia, Tele2).
To be pushed to all routers:

[edit policy-options]
+   policy-statement BGP_graceful_shutdown_out {
+       then {
+           community add GRACEFUL_SHUTDOWN;
+           next policy;
+       }
+   }

And then to specific peers (v4 or v6), when the need arises:

[edit protocols bgp group Transit4 neighbor 80.239.192.65]
+     export [ BGP_graceful_shutdown_out BGP_outfilter ];

The 2nd policy, (Eg. BGP_outfilter) needs to be adapted to match the export policy of the current peer or its parent group.

Details

	Subject	Repo	Branch	Lines +/-
	Add policy-statement BGP_graceful_shutdown_out	operations/homer/public	master	+7 -7

Customize query in gerrit

Related Objects

Mentioned In: T320230: Use Junos BGP graceful-shutdown and shutdown features
rOHPU36f5649396ca: Add policy-statement BGP_graceful_shutdown_out
T226782: a1-eqiad pdu refresh (Tuesday 10/15 @11am UTC)
Mentioned Here: T226422: update RE-S-X6-64G-S in cr[12]-codfw
T226424: (Need By: Sept 30) update RE-S-X6-64G-S in cr[12]-eqiad
T211715: Interface errors on cr1-codfw:xe-5/3/1

Event Timeline

ayounsi triaged this task as Medium priority.Dec 11 2018, 9:49 PM

ayounsi created this task.

Restricted Application added a project: SRE. · View Herald TranscriptDec 11 2018, 9:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

elukey subscribed.Dec 12 2018, 7:19 AM

Over to @faidon for review/feedback.

Have a look at https://github.com/mwiget/bgp_graceful_shutdown for a JunOS op script (SLAX) that does this fully automatically for all peers with a single command.

It does unfortunately seem to need a much newer JunOS version though, 16.1R3 or newer.

• Phabricator_maintenance moved this task from Backlog to Acknowledged on the SRE board.Jan 26 2019, 10:52 PM

Interesting! This would be useful before doing maintenance on a whole router.
I opened an issue upstream asking for a per AS option, see https://github.com/mwiget/bgp_graceful_shutdown/issues/1

My suggestion above should still be a possibility the time we upgrade to Junos >= 16 and they implement this feature.

ayounsi mentioned this in T226782: a1-eqiad pdu refresh (Tuesday 10/15 @11am UTC).Jul 24 2019, 2:37 AM

FYI I tested the policy from the description successfully during T226422 and T226424.

Reviving this... is this still waiting for my feedback? If so, LGTM :)

Change 550550 had a related patch set uploaded (by Ayounsi; owner: Ayounsi):
[operations/homer/public@master] Add policy-statement BGP_graceful_shutdown_out

https://gerrit.wikimedia.org/r/550550

Change 550550 merged by Ayounsi:
[operations/homer/public@master] Add policy-statement BGP_graceful_shutdown_out

https://gerrit.wikimedia.org/r/550550

ayounsi mentioned this in rOHPU36f5649396ca: Add policy-statement BGP_graceful_shutdown_out.Nov 12 2019, 9:03 PM