Page MenuHomePhabricator

DynamicPageList tests is failing
Closed, ResolvedPublic

Description

Hi, DynamicPageList parser tests are failing.

12:19:41 1) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=gallery (complex, with image + bad image)" ('[details omitted]')
12:19:41 Failed asserting that two strings are equal.
12:19:41 --- Expected
12:19:41 +++ Actual
12:19:41 @@ @@
12:19:41  <p><a href="/wiki/File:Foobar.svg" class="galleryfilename galleryfilename-truncate" title="File:Foobar.svg">Foobar.svg</a>
12:19:41 -240 × 180; 2 KB<br />
12:19:41 +240 × 180; 12 KB<br />
12:19:41  </p>
12:19:41  			</div>
12:19:41  		</div></li>
12:19:41  		<li class="gallerybox" style="width: 105px"><div style="width: 105px">
12:19:41  			<div class="thumb" style="width: 100px;"><div style="margin:40px auto;"><a href="/wiki/File:Thumb.png" class="image"><img alt="Thumb.png" src="http://example.com/images/thumb/e/ea/Thumb.png/70px-Thumb.png" width="70" height="70" srcset="http://example.com/images/thumb/e/ea/Thumb.png/105px-Thumb.png 1.5x, http://example.com/images/e/ea/Thumb.png 2x" /></a></div></div>
12:19:41  			<div class="gallerytext">
12:19:41  <p><a href="/wiki/File:Thumb.png" class="galleryfilename galleryfilename-truncate" title="File:Thumb.png">Thumb.png</a>
12:19:41  135 × 135; 22 KB<br />
12:19:41  </p>
12:19:41  			</div>
12:19:41  		</div></li>
12:19:41  		<li class="gallerybox" style="width: 105px"><div style="width: 105px">
12:19:41  			<div class="thumb" style="width: 100px;"><div style="margin:71px auto;"><a href="/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="http://example.com/images/thumb/3/3a/Foobar.jpg/70px-Foobar.jpg" width="70" height="8" srcset="http://example.com/images/thumb/3/3a/Foobar.jpg/105px-Foobar.jpg 1.5x, http://example.com/images/thumb/3/3a/Foobar.jpg/140px-Foobar.jpg 2x" /></a></div></div>
12:19:41  			<div class="gallerytext">
12:19:41  <p><a href="/wiki/File:Foobar.jpg" class="galleryfilename galleryfilename-truncate" title="File:Foobar.jpg">Foobar.jpg</a>
12:19:41  1,941 × 220; 8 KB<br />
12:19:41  </p>
12:19:41  			</div>
12:19:41  		</div></li>
12:19:41  </ul>
12:19:41  '
12:19:41 
12:19:41 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:53
12:19:41 /workspace/src/maintenance/doMaintenance.php:94

See https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/27701/console

Event Timeline

Paladox created this task.Dec 12 2018, 12:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2018, 12:21 PM

Change 479707 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/intersection@master] Fix tests

https://gerrit.wikimedia.org/r/479707

Change 479707 merged by jenkins-bot:
[mediawiki/extensions/intersection@master] Fix tests

https://gerrit.wikimedia.org/r/479707

Change 479739 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/intersection@REL1_32] Fix tests

https://gerrit.wikimedia.org/r/479739

Change 479739 abandoned by Paladox:
Fix tests

https://gerrit.wikimedia.org/r/479739

Paladox closed this task as Resolved.Dec 14 2018, 6:39 PM
Paladox claimed this task.
Paladox removed a project: Patch-For-Review.
Paladox removed a subscriber: gerritbot.

Change 479739 restored by Paladox:
Fix tests

https://gerrit.wikimedia.org/r/479739

Change 479739 abandoned by Paladox:
Fix tests

https://gerrit.wikimedia.org/r/479739