Page MenuHomePhabricator

Block slugs can overlap floated templates/images/etc.
Closed, ResolvedPublic

Description

Block slugs can overlap floated templates/images/etc. In rare cases this can make the floated node very difficult to click.

Example from T211518 (https://nl.wikipedia.org/w/index.php?title=Lijst_van_personen_overleden_op_15_oktober&oldid=52763852):

image.png (568×1 px, 165 KB)

Event Timeline

At a glance, this could be fixed by setting overflow: hidden; on the slug (or another property that creates a block formatting context). But we probably need to think carefully whether this can cause any issues.

image.png (568×1 px, 164 KB)

(Side note: this task looks a lot like T104540, but is much easier to fix [assuming the above idea works], since we can't blindly put overflow: hidden; on random nodes but maybe we can do it for slugs)

Change 482147 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Prevent block slugs from overlapping floated elements

https://gerrit.wikimedia.org/r/482147

Change 482147 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Prevent block slugs from overlapping floated elements

https://gerrit.wikimedia.org/r/482147

Change 482482 had a related patch set uploaded (by Divec; owner: Divec):
[mediawiki/extensions/VisualEditor@master] Update VE core module to master (469c6340e)

https://gerrit.wikimedia.org/r/482482

Change 482641 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (865754885)

https://gerrit.wikimedia.org/r/482641

Change 482641 abandoned by Esanders:
Update VE core submodule to master (865754885)

Reason:
Duplicate of Ia86cf9b23e561d3c32601d41c1bc5a9824e9953c

https://gerrit.wikimedia.org/r/482641

Change 482482 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core module to master (469c6340e)

https://gerrit.wikimedia.org/r/482482