Page MenuHomePhabricator
Create Task
Maniphest T211865

Differentiate between "all languages" and "more languages"
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To
• Lea_WMDE
Authored By
• Lea_WMDE
Dec 13 2018, 10:34 AM
Tags
Referenced Files
F26218002: Termbox-Milestone 1-fully expanded.1.1.svg
Dec 17 2018, 11:16 AM
F26217390: Termbox-Milestone 1-expanded.1_RTL.svg
Dec 17 2018, 11:16 AM
F26217385: Termbox-Milestone 1-expanded.1_RTL.jpg
Dec 17 2018, 11:16 AM
F26217448: Termbox-Milestone 1-expanded.1_portrait_2.jpg
Dec 17 2018, 11:16 AM
F26218000: Termbox-Milestone 1-fully expanded.1.1_RTL.svg
Dec 17 2018, 11:16 AM
F26302597: Bildschirmfoto 2018-10-04 um 09.14.16.png
Dec 17 2018, 11:16 AM
F26217449: Termbox-Milestone 1-expanded.1_portrait_2.svg
Dec 17 2018, 11:16 AM
F26217995: Termbox-Milestone 1-fully expanded.1.1.jpg
Dec 17 2018, 11:16 AM
View All 10 Files
Subscribers
Aklapper
gerritbot
• Hanna_Petruschat_WMDE
Jakob_WMDE
• Lea_WMDE
WMDE-leszek

Description

User Story
As a Wikidata mobile reader
I want to see the terms in all languages I can speak
in order to find out where I can help adding terms

Acceptance Criteria

  • a section containing "more languages" is shown
    • the "more languages" section contains entity information in the languages that are most likely to be spoken by the user, minus the primary language already shown above
  • a section, nested inside the "more languages" section, containing "all entered languages" is shown
    • the "all languages" section contains entity information in the languages that are not the primary language or contained in the "more languages" section
  • the "all entered languages" section is only shown if the "more languages" section is expanded
  • if the browser does not execute javascript, no further languages but the interface language are shown, but links can still be visible

Notes

  • the "all entered languages" section was previously implemented in T205261: Add the ability to show terms in all entered languages on mobile
  • section state persistence will be implemented after this is done, even though it was discussed before
  • If the languages "most likely to be spoken by the user" cannot be determined, an empty set is an acceptable return value
  • Although fancy in the mocks, the style of the links can still be "unfancy simple"

Mocks
"More languages" as first section with "all entered languages nested within"

Termbox-Milestone 1-expanded.1_RTL.jpg (667×375 px, 71 KB)

Bildschirmfoto 2018-10-04 um 09.14.16.png (622×354 px, 84 KB)

Termbox-Milestone 1-expanded.1_portrait_2.jpg (375×667 px, 76 KB)

Termbox-Milestone 1-expanded.1_portrait_2.svg475 KBDownload

Termbox-Milestone 1-expanded.1.svg531 KBDownload

Termbox-Milestone 1-expanded.1_RTL.svg520 KBDownload

all entered languages fully expanded

Termbox-Milestone 1-fully expanded.1.1.jpg (667×375 px, 93 KB)

Termbox-Milestone 1-fully expanded.1.1_RTL.jpg (667×375 px, 79 KB)

Termbox-Milestone 1-fully expanded.1.1_RTL.svg473 KBDownload

Termbox-Milestone 1-fully expanded.1.1.svg523 KBDownload

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update termboxmediawiki/extensions/Wikibasemaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lea_WMDE created this task.Dec 13 2018, 10:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2018, 10:34 AM
Liuxinyu970226 subscribed.Dec 13 2018, 10:53 AM

To me, the more languages is preferred, because the number of languages can only be more and more in anyone's life, rather than "complete in the decades future"

• Lea_WMDE triaged this task as Medium priority.Dec 17 2018, 11:16 AM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE moved this task from Backlog to MVP tickets: In preparation on the Wikidata-Termbox board.
• Lea_WMDE updated the task description. (Show Details)Dec 19 2018, 3:22 PM
• Lea_WMDE set the point value for this task to 8.
• Lea_WMDE moved this task from MVP tickets: In preparation to MVP things: Ready for pickup on the Wikidata-Termbox board.
• Lea_WMDE merged a task: T210148: Allow user specific selection of "more languages" in termbox.Jan 3 2019, 2:22 PM
WMDE-leszek added a project: Wikidata.Jan 14 2019, 1:54 PM
• Pablo-WMDE mentioned this in T214053: Hide "show in all languages" link in absence of CSR.Jan 17 2019, 3:36 PM
Jakob_WMDE edited projects, added Wikidata-Termbox-Iteration-7; removed Wikidata-Termbox.Jan 22 2019, 2:36 PM
Jakob_WMDE subscribed.Jan 23 2019, 1:39 PM

While trying to implement the server-side of this, I was somewhat surprised by the behavior. Writing it down here in case it's not just me.

Surprise 1: ULS provides the language list exclusively on the client-side. What is rendered by the server cannot be consistent with what
Surprise 2: On the server-side Wikibase takes Babel into account, whereas ULS doesn't. It is even possible that the "more languages" section is reduced after CSR is initialized.
Surprise 3: For users that are not logged in or those that do not have Babel set up, it is very likely that the list of more languages is empty.

All of this results in inconsistent SSR/CSR behavior, i.e. a very bouncy "more languages" section. The good news (I guess!?) is that this is also how the current termbox behaves.

• Lea_WMDE updated the task description. (Show Details)Jan 23 2019, 3:11 PM
• Lea_WMDE updated the task description. (Show Details)Jan 23 2019, 3:38 PM
• Lea_WMDE added a comment.Jan 23 2019, 4:00 PM

Based on storytime discussion we are going with the easiest to implement solution as a first step. This means using ULS in the Client Side Rendering, and Server Side Rendering is not part of this ticket.

WMDE-leszek subscribed.Jan 23 2019, 4:36 PM

T113573 seems to be reporting something similar to what @Jakob_WMDE describes above

Jakob_WMDE closed subtask T213736: wb: verify ParserOutput caching happens per language fallback chain permutation as Invalid.Jan 25 2019, 11:32 AM
• Lea_WMDE added a project: Wikidata-Termbox-Iteration-8.Jan 28 2019, 1:38 PM
gerritbot subscribed.Jan 28 2019, 2:53 PM

Change 486862 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/486862

gerritbot added a project: Patch-For-Review.Jan 28 2019, 2:53 PM
Jakob_WMDE closed subtask T213734: dev: add ability to set language fallback chain from URL as Resolved.Jan 28 2019, 3:36 PM
Jakob_WMDE closed subtask T213719: server: Set user's language fallback chain from request as Resolved.
Jakob_WMDE closed subtask T213732: client: Set user's language fallback chain from config as Resolved.
gerritbot added a comment.Jan 29 2019, 1:42 PM

Change 486862 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/486862

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 29 2019, 2:00 PM
Jakob_WMDE moved this task from To Do to Test (Product Review) on the Wikidata-Termbox-Iteration-8 board.Jan 29 2019, 2:31 PM

@Lea_WMDE the latest version is now on beta: https://wikidata.beta.wmflabs.org/wiki/Q11?useformat=mobile

• Lea_WMDE closed this task as Resolved.Jan 30 2019, 4:07 PM
• Lea_WMDE claimed this task.
• Lea_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-8 board.
Liuxinyu970226 unsubscribed.Feb 1 2019, 1:43 PM
• Pablo-WMDE closed subtask T213718: wb: Pass user's preferred languages from wb to SSR as Resolved.Feb 12 2019, 11:33 AM
• Pablo-WMDE reopened subtask T213718: wb: Pass user's preferred languages from wb to SSR as Open.
• Pablo-WMDE closed subtask T213720: Create "more languages" component as Resolved.
• Pablo-WMDE closed subtask T213730: Deduct languages shown in "more languages" from those shown in "all languages" as Resolved.
• Pablo-WMDE closed subtask T213718: wb: Pass user's preferred languages from wb to SSR as Resolved.
• Pablo-WMDE mentioned this in T218111: Respect user specified languages in CSR.Mar 13 2019, 6:43 PM
• Petar.petkovic removed a project: Patch-For-Review.Aug 25 2019, 6:43 AM
WMDE-leszek added a subscriber: • Hanna_Petruschat_WMDE.EditedSep 5 2019, 4:50 PM

@Hanna_Petruschat_WMDE has discovered that apparently we've managed to not add the "fewer languages" button (vs the v1 desktop termbox).
Visible on mocks but didn't make it to the acceptance criteria (unless this part was moved to some other story and I failed to notice that).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits