Page MenuHomePhabricator
Create Task
Maniphest T211897

Visual Diffs: Improve table diffing
Open, Needs TriagePublic
Actions

Description

Some of the timeouts that happen when utilizing visual diffs may be caused by edge cases around table use.

Example diffs that time out, with their table dimensions:

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update VE core submodule to master (03d0c8bb3)DLynchmediawiki/extensions/VisualEditormaster+1 -1
Update treeDiffer to 1.2.0EsandersVisualEditor/VisualEditormaster+65 -35
Update VE core submodule to master (eb7fe3518)Medeliusmediawiki/extensions/VisualEditormaster+1 -1
Use WeakMap to cache JSON.stringifyEsandersVisualEditor/VisualEditormaster+38 -4
Update VE core submodule to master (bb771ace0)DLynchmediawiki/extensions/VisualEditormaster+2 -1
Remove misplaced @abstract from ve.Node#isDiffedAsTreeThiemo Kreuz (WMDE)VisualEditor/VisualEditormaster+1 -2
Update VE core submodule to master (7e95f6c58)Esandersmediawiki/extensions/VisualEditormaster+1 -1
VisualDiff: Don't descend in non-tree nodes in tree diffEsandersVisualEditor/VisualEditormaster+160 -137
Customize query in gerrit

Related Objects
Search...

Event Timeline

• marcella created this task.Dec 13 2018, 4:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2018, 4:31 PM
• marcella added a subtask: T158445: VisualDiff: Handle table diffs separately.Dec 13 2018, 4:32 PM
• marcella added a subtask: T200476: Table row height in the VisualEditor is increased before editing cells, and after editing in VisualDiff.
• marcella added a subtask: T149851: Handle visual diffing of table cell merges.
• marcella moved this task from To Triage to Revisit on the VisualEditor board.Dec 13 2018, 4:35 PM
Tgr mentioned this in T250065: Store tabular data in a format that's machine-readable and can be shared between wikis.Apr 13 2020, 10:32 AM
Esanders updated the task description. (Show Details)Jan 17 2022, 6:31 PM
Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Jan 19 2022, 1:41 AM
Esanders updated the task description. (Show Details)Jan 19 2022, 2:03 AM
gerritbot added a comment.Jan 19 2022, 2:05 AM

Change 754609 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] VisualDiff: Don't descend in non-tree nodes in tree diff

https://gerrit.wikimedia.org/r/754609

gerritbot added a project: Patch-For-Review.Jan 19 2022, 2:05 AM
Esanders closed subtask T200476: Table row height in the VisualEditor is increased before editing cells, and after editing in VisualDiff as Resolved.Jan 20 2022, 4:56 PM
gerritbot added a comment.Mar 8 2023, 5:15 PM

Change 754609 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] VisualDiff: Don't descend in non-tree nodes in tree diff

https://gerrit.wikimedia.org/r/754609

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2023, 5:30 PM
gerritbot added a comment.Mar 9 2023, 10:35 PM

Change 896187 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e95f6c58)

https://gerrit.wikimedia.org/r/896187

gerritbot added a project: Patch-For-Review.Mar 9 2023, 10:35 PM
gerritbot added a comment.Mar 10 2023, 4:08 PM

Change 896187 merged by DLynch:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e95f6c58)

https://gerrit.wikimedia.org/r/896187

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2023, 4:11 PM
Esanders updated the task description. (Show Details)Mar 6 2025, 11:51 AM
gerritbot added a comment.Jun 8 2026, 2:05 PM

Change #1298797 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Remove misplaced @abstract from ve.Node#isDiffedAsTree

https://gerrit.wikimedia.org/r/1298797

gerritbot added a project: Patch-For-Review.Jun 8 2026, 2:05 PM
gerritbot added a comment.Jul 22 2026, 11:26 AM

Change #1298797 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Remove misplaced @abstract from ve.Node#isDiffedAsTree

https://gerrit.wikimedia.org/r/1298797

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2026, 11:31 AM
gerritbot added a comment.Jul 23 2026, 9:38 PM

Change #1315094 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bb771ace0)

https://gerrit.wikimedia.org/r/1315094

gerritbot added a project: Patch-For-Review.Jul 23 2026, 9:38 PM
gerritbot added a comment.Jul 23 2026, 10:38 PM

Change #1315094 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bb771ace0)

https://gerrit.wikimedia.org/r/1315094

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2026, 11:31 PM
gerritbot added a comment.Jul 28 2026, 11:06 AM

Change #1315990 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Use WeakMap to cache JSON.stringify

https://gerrit.wikimedia.org/r/1315990

gerritbot added a project: Patch-For-Review.Jul 28 2026, 11:06 AM

Change #1315994 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Update treeDiffer to 1.2.0

https://gerrit.wikimedia.org/r/1315994

gerritbot added a comment.Jul 30 2026, 6:51 PM

Change #1315990 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Use WeakMap to cache JSON.stringify

https://gerrit.wikimedia.org/r/1315990

gerritbot added a comment.Jul 31 2026, 8:58 PM

Change #1319896 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1b770f4be)

https://gerrit.wikimedia.org/r/1319896

gerritbot added a comment.Jul 31 2026, 11:14 PM

Change #1319896 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (eb7fe3518)

https://gerrit.wikimedia.org/r/1319896

gerritbot added a comment.Sep 2 2026, 11:32 PM

Change #1315994 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Update treeDiffer to 1.2.0

https://gerrit.wikimedia.org/r/1315994

gerritbot added a comment.Sep 2 2026, 11:32 PM

Change #1334137 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (03d0c8bb3)

https://gerrit.wikimedia.org/r/1334137

gerritbot added a comment.Sep 2 2026, 11:46 PM

Change #1334137 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (03d0c8bb3)

https://gerrit.wikimedia.org/r/1334137

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.19; 2026-09-08).Sep 3 2026, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2026, 12:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits