Maniphest T211897

Visual Diffs: Improve table diffing
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	• marcella
	Dec 13 2018, 4:31 PM

Tags

Referenced Files

None

Subscribers

Description

Some of the timeouts that happen when utilizing visual diffs may be caused by edge cases around table use.

Example diffs that time out, with their table dimensions:

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (7e95f6c58)	mediawiki/extensions/VisualEditor	master	+1 -1
	VisualDiff: Don't descend in non-tree nodes in tree diff	VisualEditor/VisualEditor	master	+160 -137

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T211897 Visual Diffs: Improve table diffing
		Open		None	T158445 VisualDiff: Handle table diffs separately
		Resolved		Tchanders	T158294 Cell change missing in table diff
		Resolved		Esanders	T200476 Table row height in the VisualEditor is increased before editing cells, and after editing in VisualDiff
		Open		None	T149851 Handle visual diffing of table cell merges
		Open		None	T393694 Truncate unchanged parts of a table in table diffs

Event Timeline

• marcella created this task.Dec 13 2018, 4:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2018, 4:31 PM

• marcella added a subtask: T158445: VisualDiff: Handle table diffs separately.Dec 13 2018, 4:32 PM

• marcella added a subtask: T200476: Table row height in the VisualEditor is increased before editing cells, and after editing in VisualDiff.

• marcella added a subtask: T149851: Handle visual diffing of table cell merges.

• marcella moved this task from To Triage to Revisit on the VisualEditor board.Dec 13 2018, 4:35 PM

Tgr mentioned this in T250065: Store tabular data in a format that's machine-readable and can be shared between wikis.Apr 13 2020, 10:32 AM

Esanders updated the task description. (Show Details)Jan 17 2022, 6:31 PM

Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Jan 19 2022, 1:41 AM

Esanders updated the task description. (Show Details)Jan 19 2022, 2:03 AM

Change 754609 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] VisualDiff: Don't descend in non-tree nodes in tree diff

https://gerrit.wikimedia.org/r/754609

gerritbot added a project: Patch-For-Review.Jan 19 2022, 2:05 AM

Esanders closed subtask T200476: Table row height in the VisualEditor is increased before editing cells, and after editing in VisualDiff as Resolved.Jan 20 2022, 4:56 PM

Change 754609 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] VisualDiff: Don't descend in non-tree nodes in tree diff

https://gerrit.wikimedia.org/r/754609

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2023, 5:30 PM

Change 896187 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e95f6c58)

https://gerrit.wikimedia.org/r/896187

gerritbot added a project: Patch-For-Review.Mar 9 2023, 10:35 PM

Change 896187 merged by DLynch:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e95f6c58)

https://gerrit.wikimedia.org/r/896187

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2023, 4:11 PM

Esanders updated the task description. (Show Details)Mar 6 2025, 11:51 AM