@Gilles @Krinkle Based on the work that you've been doing with NavTiming over the last few months, is this something that would be easy to do? (Either add a header to the response that specifies whether the page in question was served by PHP7/HHVM, or reading the cookie that we'll be setting on the client side to direct people to the A/B group.)
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T176370 Migrate to PHP 7 in WMF production | |||
| Resolved | • Gilles | T211906 Expose PHP7/HHVM to NavTiming in a header, send with navtiming beacon so we can use it as a dimension |
Event Timeline
Comment Actions
If there's already a cookie planned to enable that, I think that's the easiest thing to use here. Server-Timing has limited cross-browser support at this point: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Server-Timing
Comment Actions
During the HHVM rollout, mw.config.get( 'wgPoweredByHHVM' ) would tell you if the page was being rendered via HHVM or not: rEWMV973c7340e75f: Inject 'wgPoweredByHHVM' JS config var if powered by HHVM
Comment Actions
The application server layer https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/production/modules/mediawiki/templates/apache/mediawiki-vhost.conf.erb#14, and the caching layer https://gerrit.wikimedia.org/r/c/operations/puppet/+/478680/6/modules/varnish/templates/text-frontend.inc.vcl.erb are set to recognize the cookie PHP_ENGINE and send traffic to php-fpm if the value is php7.
Responses from php and hhvm can be told apart from their X-Powered-By header too.
I think we can do the same thing that was done back in the day - expose the rendering engine as a config value that can be used directly in javascript.
Comment Actions
Change 516470 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/extensions/NavigationTiming@master] Record PHP engine used to render the page
Comment Actions
Change 516470 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Record PHP engine used to render the page
Comment Actions
It's now being recorded:
SELECT event.phpEngine, COUNT(*) FROM event.navigationtiming WHERE year = 2019 AND month = 6 AND day = 19 GROUP BY event.phpEngine; phpengine _c1 NULL 247326 hhvm 120138 zend 18766
Comment Actions
Change 517866 had a related patch set uploaded (by Gilles; owner: Gilles):
[analytics/refinery@master] Retain new phpEngine field in NavigationTiming
Comment Actions
Change 517866 merged by Nuria:
[analytics/refinery@master] Retain new phpEngine field in NavigationTiming