Page MenuHomePhabricator

MFA: View and Icon test coverage to 100%
Open, Needs TriagePublic

Description

The View and Icon classes are widely used inside MobileFrontend but do not enjoy good code coverage.

File% Stmts% Branch% Funcs% LinesUncovered Line #s
Icon.js58.3333.3310058.33... 48,50,51,53,55
View.js93.1584.3888.2493.06... 99,201,202,396

Acceptance criteria

  • 100% test coverage for both or good documented reasons why this is not possible.

Sign off steps

Event Timeline

Jdlrobson triaged this task as High priority.Dec 13 2018, 11:36 PM
Jdlrobson created this task.
Jdlrobson updated the task description. (Show Details)Dec 13 2018, 11:39 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from AMC: View and Icon test coverage to 100% to MFA: View and Icon test coverage to 100%.Dec 17 2018, 4:38 PM
Jdlrobson lowered the priority of this task from High to Normal.Dec 18 2018, 12:38 AM
Jdlrobson moved this task from Backlog to Tech debt on the MinervaNeue board.Feb 5 2019, 6:50 PM
Jdlrobson raised the priority of this task from Normal to Needs Triage.Feb 26 2019, 7:10 PM

This appears to be the last task blocking T195478 resolution. Offhandedly, ~90% View coverage sounds great but maybe Icon's tests can be improved.

I'd take the fact this is the only subtask with a pinch of salt. We are improving coverage as part of refactoring so maybe that epic should be a subtask of this one.

In https://m.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture/Progress#Automate_asset_bundling I split this into two epics. If that's helpful we could also do that here.