View.test.js initializes jQuery before calling JSDom.
This should result in a failing test, however, because the previous test, Skin.test.js, doesn't tear down jQuery, View.test.js still has access to that old jQuery instance, and the tests pass.
When the order of the tests changes however, View.test.js no longer has access to the old jQuery instance and the View.test.js test fails.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Ensure View.test.js sets up JSDom before jQuery | mediawiki/extensions/MobileFrontend | master | +13 -5 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T210517 [Spike, 8hrs] [Bug] Skin.test.js should call jQuery.tearDown() | |||
| Resolved | Jdrewniak | T211963 View.test.js should call JSDom before initializing jQuery |
Change 479593 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/MobileFrontend@master] Ensure View.test.js sets up JSDom before jQuery
Change 479593 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Ensure View.test.js sets up JSDom before jQuery