Edit summary label broken
Closed, DeclinedPublic

Assigned To
siebrand, werdna, MER-C and 2 others


If [[MediaWiki:Summary]] contains HTML, after the scap to r51863 the label for the edit summary text field reads

<a href="/wiki/Help:Edit_summary" class='internal' title="Briefly describe the changes you have made" target="_blank">Edit summary</a> (Briefly describe the changes you have made)

The HTML should actually be rendered by the browser. Confirmed on en and simple.


Screenshot attached

Version: 1.16.x
Severity: normal


bzimport added a project: MediaWiki-Page-editing.Via ConduitNov 21 2014, 10:43 PM
bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz19200.
MER-C created this task.Via LegacyJun 15 2009, 9:14 AM
siebrand added a comment.Via ConduitJun 15 2009, 9:22 AM

Looks like this behaviour may have been changed in r50882

werdna added a comment.Via ConduitJun 15 2009, 9:24 AM

Changing messages from HTML to wikitext is a good idea generally.

bzimport added a comment.Via ConduitJun 15 2009, 9:36 AM

lastword wrote:

The < has been changed to a &lt; entity, which is why it doesn't render. (System message affected is MediaWiki:Summary.) Siebrand has identified the correct change, I think. The message uses HTML rather than wikitext because it wishes to open the link to Help:Edit summary in a new window (which I don't think wikitext can do). If it opens in the same window, users of suboptimal browsers who click to read about edit summaries will lose any edits they've made when clicking the back button.

siebrand added a comment.Via ConduitJun 15 2009, 10:57 AM

WONTFIX per comment 2.

bzimport added a comment.Via ConduitJun 16 2009, 10:06 AM

herd wrote:

To anyone directed here from WMF wikis:

Per the WONTFIX, I've enlisted some steward help to remove some of the more awful breaks in this message.

Note that it was a valid concern to use <a target="_new"> or _blank or such for browsers that would not cache the edit page if you left it, but inserting raw <script> into this message is very bad. Please migrate any javascript to MediaWiki:Common.js (for things like addTags, use innerHTML or createElement to add the links anywhere on the edit page). The <a target> can also be done via javascript http://en.wikipedia.org/wiki/User:Dinoguy1000/scripts/safeIEeditlinks.js (though this is a stopgap fix).

bzimport added a comment.Via ConduitJun 16 2009, 11:09 PM

overlordq wrote:

*** Bug 19250 has been marked as a duplicate of this bug. ***

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.