Maniphest T212041

Prohibit trailing whitespace in messages
Open, LowPublic
Actions

Assigned To

None

Authored By

	Urbanecm
	Dec 15 2018, 3:56 PM

Description

Problem

Developers sometimes unintentionally add a message with trailing whitespace. This can confuse translator community in translatewiki.net (translatewiki software adds a backslash as an indicator to not trim the message). Since trailing whitespace is never meaningful in those messages, it's safe to prohibit them.

Proposed solution

Add a test that prohibits trailing whitespace in messages (django.pot/djangojs.pot and also all other .pot files which may be added in the future).

Student is expected to send a patch for wikimedia-cz/tracker repository, hosted at Wikimedia Gerrit. When claiming task on GCI website, student should claim a respective Phabricator task as well.

Materials

Tracker in production
Test Tracker version - you can play with Tracker freely here
Codebase

Details

	Subject	Repo	Branch	Lines +/-
	Prohibit trailing whitespace in messages	wikimedia-cz/tracker	master	+32 -0

Customize query in gerrit

Related Objects

Mentioned In: T212031: [[Wikimedia:Tracker-588962-Your CSV file was imported. \/fr]] translation issue EN messages ending with a backslash '\' character

Event Timeline

Urbanecm created this task.Dec 15 2018, 3:56 PM

Urbanecm moved this task from Inbox to Ready (PM's approval not needed) on the WMCZ-Tracker board.

Urbanecm mentioned this in T212031: [[Wikimedia:Tracker-588962-Your CSV file was imported. \/fr]] translation issue EN messages ending with a backslash '\' character.

Urbanecm triaged this task as Medium priority.Dec 16 2018, 8:21 PM

I couldn't find Grunt plugin for this.
Maybe I could try to make one?
This is maybe a good option: JSON.parse(messageFile) and then JSON.stringify(result, null, 4) <-- indent value
or using Regex?

JSON.parse(messageFile) - I don't know what's messageFile in this context, but django.pot isn't JSON.

Anyway, feel free to try to complete those tasks, I'm not working on them (unless I claim them) :).

Urbanecm added a project: User-Urbanecm.Aug 25 2019, 11:57 PM

Urbanecm moved this task from Backlog to GCI on the User-Urbanecm board.Aug 25 2019, 11:59 PM

Urbanecm renamed this task from Prohibit trailing spaces in messages to Prohibit trailing whitespace in messages.Aug 26 2019, 4:00 PM

Urbanecm added a project: Google-Code-in-2019.

Urbanecm updated the task description. (Show Details)

Urbanecm moved this task from Ready (PM's approval not needed) to GCI on the WMCZ-Tracker board.Aug 26 2019, 5:08 PM

Urbanecm updated the task description. (Show Details)Oct 12 2019, 4:55 PM

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Oct 29 2019, 7:32 PM

Urbanecm removed a project: User-Urbanecm.Nov 24 2019, 7:36 PM

Userring claimed this task.Jan 9 2020, 12:21 AM

Userring subscribed.

Change 563686 had a related patch set uploaded (by RishabhL; owner: RishabhL):
[wikimedia-cz/tracker@master] Prohibit trailing whitespace in messages

https://gerrit.wikimedia.org/r/563686

gerritbot added a project: Patch-For-Review.Jan 11 2020, 8:08 PM

Urbanecm lowered the priority of this task from Medium to Low.Jul 21 2020, 10:25 PM

Urbanecm added a project: good first task.Jul 21 2020, 10:27 PM

Urbanecm moved this task from GCI to Ready (PM's approval not needed) on the WMCZ-Tracker board.Jul 21 2020, 10:28 PM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Feb 3 2022, 4:31 PM

Userring removed Userring as the assignee of this task.Feb 7 2022, 1:25 AM

Userring unsubscribed.

Prohibit trailing whitespace in messagesOpen, LowPublicActions