Maniphest T212058

Drop FlaggedRevs rights from users at srwikinews
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Kizule
	Dec 15 2018, 10:53 PM

Description

At T209251, FlaggedRevs extension is disabled on srwikinews, but there are still rights from this extension.

Can you remove old rights which this extension provided before please? I promoted users with old rights to new, so they will not be problems with losing rights.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Kizule	T209251 Remove FlaggedRevs and add back rights autopatrolled, patroller (with enabled RCPatrol), rollbacker on srwikinews
		Resolved		Catrope	T212058 Drop FlaggedRevs rights from users at srwikinews

Event Timeline

Kizule created this task.Dec 15 2018, 10:53 PM

Restricted Application added subscribers: • Petar.petkovic, Aklapper. · View Herald TranscriptDec 15 2018, 10:53 PM

Kizule added a parent task: T209251: Remove FlaggedRevs and add back rights autopatrolled, patroller (with enabled RCPatrol), rollbacker on srwikinews.Dec 15 2018, 10:56 PM

Should https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/maintenance/emptyUserGroup.php do this?

Kizule added a project: DBA.Dec 16 2018, 11:12 PM

I guess adding the DBA tag is to ask for a script review?
The script looks good, it has wait for replication. However, if it is not too much work, ideally if you are going to run DELETEs, it might be safer to run them on small batches, of maybe 100 or 200 rows, so we avoid big large transactions.
I will remain subscribed to the task

In T212058#4827428, @Marostegui wrote:

I guess adding the DBA tag is to ask for a script review?
The script looks good, it has wait for replication. However, if it is not too much work, ideally if you are going to run DELETEs, it might be safer to run them on small batches, of maybe 100 or 200 rows, so we avoid big large transactions.
I will remain subscribed to the task

No for review of script. I added DBA because I thinked to DBA do this.

No, we do not run maintenance scripts :-)

Aklapper edited projects, added Wikimedia-maintenance-script-run; removed MediaWiki-Maintenance-system.Dec 17 2018, 11:45 AM

Framawiki subscribed.Dec 19 2018, 9:01 PM

In T212058#4827428, @Marostegui wrote:

I guess adding the DBA tag is to ask for a script review?
The script looks good, it has wait for replication. However, if it is not too much work, ideally if you are going to run DELETEs, it might be safer to run them on small batches, of maybe 100 or 200 rows, so we avoid big large transactions.
I will remain subscribed to the task

@Marostegui There is not much users with these rights. I checked database and found 47 rows for three rights of FlaggedRevs extension which I requested for removal from users at this task. See:

P7958 T212058

1	MariaDB [srwikinews_p]> SELECT * FROM user_groups WHERE ug_group='autoreview';
2	+---------+------------+-----------+
3	\| ug_user \| ug_group \| ug_expiry \|
4	+---------+------------+-----------+
5	\| 7 \| autoreview \| NULL \|
6	\| 34 \| autoreview \| NULL \|
7	\| 84 \| autoreview \| NULL \|
8	\| 280 \| autoreview \| NULL \|
9	\| 452 \| autoreview \| NULL \|
10	\| 628 \| autoreview \| NULL \|
11	\| 730 \| autoreview \| NULL \|
12	\| 799 \| autoreview \| NULL \|
13	\| 2414 \| autoreview \| NULL \|
14	\| 2497 \| autoreview \| NULL \|
15	\| 2520 \| autoreview \| NULL \|
16	\| 2523 \| autoreview \| NULL \|
17	\| 2524 \| autoreview \| NULL \|
18	\| 2527 \| autoreview \| NULL \|
19	\| 2774 \| autoreview \| NULL \|
20	\| 4151 \| autoreview \| NULL \|
21	\| 5552 \| autoreview \| NULL \|
22	+---------+------------+-----------+
23	17 rows in set (0.00 sec)
24
25	MariaDB [srwikinews_p]>
26
27	MariaDB [srwikinews_p]> SELECT * FROM user_groups WHERE ug_group='reviewer';
28	+---------+----------+-----------+
29	\| ug_user \| ug_group \| ug_expiry \|
30	+---------+----------+-----------+
31	\| 4 \| reviewer \| NULL \|
32	\| 6 \| reviewer \| NULL \|
33	\| 10 \| reviewer \| NULL \|
34	\| 162 \| reviewer \| NULL \|
35	\| 232 \| reviewer \| NULL \|
36	\| 280 \| reviewer \| NULL \|
37	\| 317 \| reviewer \| NULL \|
38	\| 452 \| reviewer \| NULL \|
39	\| 620 \| reviewer \| NULL \|
40	\| 628 \| reviewer \| NULL \|
41	\| 732 \| reviewer \| NULL \|
42	\| 2497 \| reviewer \| NULL \|
43	\| 5552 \| reviewer \| NULL \|
44	+---------+----------+-----------+
45	13 rows in set (0.01 sec)
46
47	MariaDB [srwikinews_p]>
48
49	MariaDB [srwikinews_p]> SELECT * FROM user_groups WHERE ug_group='editor';
50	+---------+----------+-----------+
51	\| ug_user \| ug_group \| ug_expiry \|
52	+---------+----------+-----------+
53	\| 4 \| editor \| NULL \|
54	\| 6 \| editor \| NULL \|
55	\| 10 \| editor \| NULL \|
56	\| 34 \| editor \| NULL \|
57	\| 105 \| editor \| NULL \|
58	\| 162 \| editor \| NULL \|
59	\| 232 \| editor \| NULL \|
60	\| 317 \| editor \| NULL \|
61	\| 452 \| editor \| NULL \|
62	\| 620 \| editor \| NULL \|
63	\| 628 \| editor \| NULL \|
64	\| 656 \| editor \| NULL \|
65	\| 708 \| editor \| NULL \|
66	\| 732 \| editor \| NULL \|
67	\| 2414 \| editor \| NULL \|
68	\| 4151 \| editor \| NULL \|
69	\| 5552 \| editor \| NULL \|
70	+---------+----------+-----------+
71	17 rows in set (0.00 sec)
72
73	MariaDB [srwikinews_p]>

Ah, I see. That are not many rows :-)
Should be fine to run the script anytime

In T212058#4855320, @Marostegui wrote:

Ah, I see. That are not many rows :-)
Should be fine to run the script anytime

Ok. So, can anyone from SRE to run this script? Thanks!

Can anyone confirm to this is correct:

mwscript emptyUserGroup.php autoreview --wiki=srwikinews
mwscript emptyUserGroup.php reviewer --wiki=srwikinews
mwscript emptyUserGroup.php editor --wiki=srwikinews

Mentioned in SAL (#wikimedia-operations) [2019-01-07T19:10:59Z] <RoanKattouw> Ran emptyUserGroup.php for autoreview, reviewer and editor groups on srwikinews (T212058)

Catrope closed this task as Resolved.Jan 7 2019, 7:11 PM

Catrope claimed this task.