Page MenuHomePhabricator
Create Task
Maniphest T212076

proofreadpage_tests.TestPageOCR.test_ocr_googleocr sometimes fails with ValueError
Closed, ResolvedPublic
Actions

Description

======================================================================
 4801ERROR: test_ocr_googleocr (tests.proofreadpage_tests.TestPageOCR)
 4802Test page.ocr(ocr_tool='googleOCR').
 4803----------------------------------------------------------------------
 4804Traceback (most recent call last):
 4805  File "c:\projects\pywikibot-g4xqx\tests\proofreadpage_tests.py", line 393, in test_ocr_googleocr
 4806    text = self.page.ocr(ocr_tool='googleOCR')
 4807  File "c:\projects\pywikibot-g4xqx\pywikibot\proofreadpage.py", line 725, in ocr
 4808    raise ValueError('%s: not possible to perform OCR.' % self)
 4809ValueError: [[wikisource:en:Page:Popular Science Monthly Volume 1.djvu/10]]: not possible to perform OCR.
 4810
 4811======================================================================
 4812FAIL: test_do_ocr_googleocr (tests.proofreadpage_tests.TestPageOCR)
 4813Test page._do_ocr(ocr_tool='googleOCR').
 4814----------------------------------------------------------------------
 4815Traceback (most recent call last):
 4816  File "c:\projects\pywikibot-g4xqx\tests\proofreadpage_tests.py", line 388, in test_do_ocr_googleocr
 4817    self.assertEqual(error, ref_error)
 4818AssertionError: True != False
 4819

Details

SubjectRepoBranchLines +/-
proofreadpage.py: handle http response code in OCR methodspywikibot/coremaster+16 -24
proofreadpage_tests.py: add error text to Exceptionpywikibot/coremaster+2 -1
Customize query in gerrit

Event Timeline

Xqt created this task.Dec 16 2018, 10:19 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptDec 16 2018, 10:19 AM
Xqt triaged this task as High priority.Dec 16 2018, 10:19 AM
Framawiki subscribed.Dec 16 2018, 1:54 PM
Mpaa added a comment.Dec 16 2018, 6:08 PM

I think it is has been a temporary unavailability of googleOCR service.

Xqt added a comment.Dec 17 2018, 4:30 AM
In T212076#4826607, @Mpaa wrote:

I think it is has been a temporary unavailability of googleOCR service.

Can we check this and give an appropriate message?

Dvorapa subscribed.EditedDec 17 2018, 6:27 AM
In T212076#4826944, @Xqt wrote:
In T212076#4826607, @Mpaa wrote:

I think it is has been a temporary unavailability of googleOCR service.

Can we check this and give an appropriate message?

I agree. BTW this would be great for every external tool we use (e.g. from tools.wmflabs.org, there was a problem recently with some tool from that source).

Xqt added a comment.EditedDec 18 2018, 5:31 AM

In this sample googleocr was available but the result is different

Mpaa added a comment.Dec 19 2018, 6:06 PM

I copy it here for convenience.
Interesting, it looks like googleOCR answer is not deterministic or some bytes are lost somewhere.

FAIL: test_ocr_googleocr (tests.proofreadpage_tests.TestPageOCR)
Test page.ocr(ocr_tool='googleOCR').
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/wikimedia/pywikibot/tests/proofreadpage_tests.py", line 395, in test_ocr_googleocr
    self.assertEqual(text, ref_text)
AssertionError: u'ENTERED, according to Act of Congress, in the year 1572,\nB D. APPLETON &CO\nI [truncated]... != u'ENTERED, according to Act of Congress, in the year 1572,\nBY D. APPLETON & CO. [truncated]...
  ENTERED, according to Act of Congress, in the year 1572,
- B D. APPLETON &CO
+ BY D. APPLETON & CO.
?  +              +  +
  In the Office of the Librarian of Congress, at Washington.
  4 334
gerritbot subscribed.Dec 19 2018, 6:40 PM

Change 480810 had a related patch set uploaded (by Mpaa; owner: Mpaa):
[pywikibot/core@master] proofreadpage_tests.py: add error text to Exception

https://gerrit.wikimedia.org/r/480810

gerritbot added a project: Patch-For-Review.Dec 19 2018, 6:40 PM
gerritbot added a comment.Dec 19 2018, 8:03 PM

Change 480810 merged by jenkins-bot:
[pywikibot/core@master] proofreadpage_tests.py: add error text to Exception

https://gerrit.wikimedia.org/r/480810

xSavitar moved this task from Backlog to Needs Review on the Pywikibot board.Dec 22 2018, 6:16 PM
Xqt removed a project: Patch-For-Review.Feb 3 2019, 11:45 AM
Xqt moved this task from Needs Review to Backlog on the Pywikibot board.
Xqt lowered the priority of this task from High to Medium.Feb 7 2019, 9:39 AM
Xqt added a comment.Feb 16 2019, 11:25 AM

Now we have a json.decoder.JSONDecodeError:

https://ci.appveyor.com/project/ladsgroup/pywikibot-g4xqx/build/job/dhuv540dipdiw9si

gerritbot added a comment.Feb 16 2019, 6:57 PM

Change 491008 had a related patch set uploaded (by Mpaa; owner: Mpaa):
[pywikibot/core@master] proofreadpage.py: handle http response code in OCR methods

https://gerrit.wikimedia.org/r/491008

gerritbot added a project: Patch-For-Review.Feb 16 2019, 6:57 PM
Mpaa added a comment.Feb 16 2019, 6:58 PM
In T212076#4959217, @Xqt wrote:

Now we have a json.decoder.JSONDecodeError:

https://ci.appveyor.com/project/ladsgroup/pywikibot-g4xqx/build/job/dhuv540dipdiw9si

This time was:
[00:06:55] Test page._do_ocr(ocr_tool='googleOCR'). ... WARNING: Http response status 404

gerritbot added a comment.Feb 16 2019, 7:28 PM

Change 491008 merged by jenkins-bot:
[pywikibot/core@master] proofreadpage.py: handle http response code in OCR methods

https://gerrit.wikimedia.org/r/491008

Xqt closed this task as Resolved.Feb 18 2019, 3:01 AM
Xqt claimed this task.
Xqt reassigned this task from Xqt to Mpaa.

I close it as resolved because the failure does not occur anymore. Can be re-opened if we have it again.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL