Page MenuHomePhabricator

Score does not work if the file is from a external provider such as wmf commons
Open, Needs TriagePublic

Description

Hi, it seems that "score" the extension does not work if the file is from wmf commons (or another ForeignAPIFile)

Some notes from @Southparkfan:

20:25:50 <SPF|Cloud> https://github.com/wikimedia/mediawiki-extensions-Score/blob/master/includes/Score.php#L459 if $options['midi_file'] refers to a ForeignAPIFile object (because it's a midi file from wikimedia commons) getLocalRefPath() returns (bool)false thus the shell command (https://github.com/wikimedia/mediawiki-extensions-Score/blob/master/includes/Score.php#L872) fails
20:26:25 <SPF|Cloud> shouldn't the extension fetch the file from wikimedia commons before attempting to generate the audio file?

We are running mediawiki 1.31 and php7.2.

Event Timeline

Paladox created this task.Dec 16 2018, 10:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2018, 10:37 PM
mb added a subscriber: mb.Dec 17 2018, 12:28 AM
Ebe123 claimed this task.Dec 19 2018, 4:58 AM
Ebe123 added a subscriber: Ebe123.

External bug ref: https://phabricator.miraheze.org/T3649 - Try updating the extension, some work has been done since April.

Hi, it dosen't seem to work with the master branch of score either.

I see this "Uncaught (in promise) DOMException" in the console though.

Any updates on this?

Ebe123 added a comment.Aug 8 2019, 2:58 PM

Not really any updates on this; but the whole functionality will be deprecated as TMH can convert MIDI files without need from Score.