Edit summary for adding a caption uses “[1]” instead of language code
Closed, ResolvedPublic
Actions

Description

When I added a caption to a random file on Beta Commons, this was the automatic comment:

Added [1] caption: a blank, black image

I assume the “[1]” is supposed to be a language code (“[en]”)?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	i18n: Fix wbsetlabel-* to use $2 (the language) not $1 (the number changed, always 1)	mediawiki/extensions/WikibaseMediaInfo	master	+6 -6

Customize query in gerrit

Related Objects

Mentioned In: rEWBIb2a2ba203aa5: i18n: Fix wbsetlabel-* to use $2 (the language) not $1 (the number changed…
T213892: Edit summary for operations on File captions should include the language of the caption
rEWBIb5c59e76b800: i18n: Fix wbsetlabel-* to use $2 (the language) not $1 (the number changed…

Event Timeline

LucasWerkmeister created this task.Dec 17 2018, 9:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2018, 9:50 PM

LucasWerkmeister added a project: StructuredDataOnCommons.Dec 17 2018, 10:02 PM

Assigning this to Cormac for the moment because I *think* he did something with this code a while ago.

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Dec 17 2018, 10:49 PM

Pinging @Cparle on this one again because it's the last known "real" bug for captions :)

Change 483871 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] i18n: Fix wbsetlabel-* to use $2 (the language) not $1 (the number changed, always 1)

https://gerrit.wikimedia.org/r/483871

gerritbot added a project: Patch-For-Review.Jan 11 2019, 10:19 PM

Wikibase is a maze of fun.

Jdforrester-WMF mentioned this in rEWBIb5c59e76b800: i18n: Fix wbsetlabel-* to use $2 (the language) not $1 (the number changed….Jan 11 2019, 10:20 PM

Change 483871 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] i18n: Fix wbsetlabel-* to use $2 (the language) not $1 (the number changed, always 1)

https://gerrit.wikimedia.org/r/483871

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 14 2019, 12:01 PM

Cparle moved this task from To Do to Needs QA on the Multimedia-Team-Working-Board board.Jan 14 2019, 12:22 PM

Raymond merged a task: T213650: Variable $1 of message "Wikibase-mediainfo-summary-wbsetlabel-add" filled wrongly.Jan 14 2019, 12:38 PM

Raymond subscribed.

Jdforrester-WMF removed a project: Patch-For-Review.Jan 14 2019, 4:56 PM

Jdforrester-WMF moved this task from Doing to Verify on Production on the Structured Data Engineering board.

Jdforrester-WMF mentioned this in T213892: Edit summary for operations on File captions should include the language of the caption.Jan 16 2019, 7:50 PM

Jdforrester-WMF merged a task: T213892: Edit summary for operations on File captions should include the language of the caption.

Jdforrester-WMF added a subscriber: JeanFred.

I believe this went live and appears to be working :) Time to close?